Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/Source/core/loader/PingLoader.cpp

Issue 2712833002: DevTools: Show decoded body length for network requests on timeline. (Closed)
Patch Set: rebaseline Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/PingLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/PingLoader.cpp b/third_party/WebKit/Source/core/loader/PingLoader.cpp
index 6afde83f2368e9eb360675f1a959aa8838089739..aa1817f8bf6e7b25a3e268a869fa58e25501e9cc 100644
--- a/third_party/WebKit/Source/core/loader/PingLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/PingLoader.cpp
@@ -342,8 +342,9 @@ bool PingLoaderImpl::willFollowRedirect(
void PingLoaderImpl::didReceiveResponse(const WebURLResponse& response) {
if (frame()) {
- TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",
- InspectorResourceFinishEvent::data(m_identifier, 0, true, 0));
+ TRACE_EVENT1(
+ "devtools.timeline", "ResourceFinish", "data",
+ InspectorResourceFinishEvent::data(m_identifier, 0, true, 0, 0));
const ResourceResponse& resourceResponse = response.toResourceResponse();
InspectorInstrumentation::didReceiveResourceResponse(
frame(), m_identifier, 0, resourceResponse, 0);
@@ -354,9 +355,9 @@ void PingLoaderImpl::didReceiveResponse(const WebURLResponse& response) {
void PingLoaderImpl::didReceiveData(const char*, int dataLength) {
if (frame()) {
- TRACE_EVENT1(
- "devtools.timeline", "ResourceFinish", "data",
- InspectorResourceFinishEvent::data(m_identifier, 0, true, dataLength));
+ TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",
+ InspectorResourceFinishEvent::data(m_identifier, 0, true,
+ dataLength, 0));
didFailLoading(frame());
}
dispose();
@@ -368,7 +369,7 @@ void PingLoaderImpl::didFinishLoading(double,
if (frame()) {
TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",
InspectorResourceFinishEvent::data(m_identifier, 0, true,
- encodedDataLength));
+ encodedDataLength, 0));
didFailLoading(frame());
}
dispose();
@@ -380,7 +381,7 @@ void PingLoaderImpl::didFail(const WebURLError& resourceError,
if (frame()) {
TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",
InspectorResourceFinishEvent::data(m_identifier, 0, true,
- encodedDataLength));
+ encodedDataLength, 0));
didFailLoading(frame());
}
dispose();
@@ -388,8 +389,9 @@ void PingLoaderImpl::didFail(const WebURLError& resourceError,
void PingLoaderImpl::timeout(TimerBase*) {
if (frame()) {
- TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",
- InspectorResourceFinishEvent::data(m_identifier, 0, true, 0));
+ TRACE_EVENT1(
+ "devtools.timeline", "ResourceFinish", "data",
+ InspectorResourceFinishEvent::data(m_identifier, 0, true, 0, 0));
didFailLoading(frame());
}
dispose();

Powered by Google App Engine
This is Rietveld 408576698