Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2712793002: chromeos: Adds AshDevToolsTest to common_unittests (Closed)

Created:
3 years, 10 months ago by sky
Modified:
3 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Adds AshDevToolsTest to common_unittests This makes it run in both ash_unittests and mash_unittests. I had to update one of the tests. In particular it was setting a new size of the widget, but the size had non effect on ash (because of different minimum size) where as it does on mash. I increased the size so that the new size triggers a resize on both, and I changed some names for improved readability. BUG=693114 TEST=covered by tests Review-Url: https://codereview.chromium.org/2712793002 Cr-Commit-Position: refs/heads/master@{#452392} Committed: https://chromium.googlesource.com/chromium/src/+/73b3f2563cca092c6ddbe6a9f3a87fdbd30e798e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M ash/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ash/common/devtools/ash_devtools_unittest.cc View 2 chunks +24 lines, -21 lines 1 comment Download

Messages

Total messages: 14 (9 generated)
sky
https://codereview.chromium.org/2712793002/diff/1/ash/common/devtools/ash_devtools_unittest.cc File ash/common/devtools/ash_devtools_unittest.cc (right): https://codereview.chromium.org/2712793002/diff/1/ash/common/devtools/ash_devtools_unittest.cc#newcode682 ash/common/devtools/ash_devtools_unittest.cc:682: gfx::Rect widget_bounds(10, 10, 150, 160); This and increasing the ...
3 years, 10 months ago (2017-02-22 20:44:51 UTC) #1
sky
3 years, 10 months ago (2017-02-23 04:28:43 UTC) #8
sadrul
lgtm
3 years, 10 months ago (2017-02-23 04:30:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712793002/1
3 years, 10 months ago (2017-02-23 04:36:43 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 04:41:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73b3f2563cca092c6ddbe6a9f3a8...

Powered by Google App Engine
This is Rietveld 408576698