chromeos: Adds AshDevToolsTest to common_unittests

ash/common/devtools/ash_devtools_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/devtools/ash_devtools_css_agent.h"
 #include "ash/common/devtools/ash_devtools_dom_agent.h"
 #include "ash/common/test/ash_test.h"
 #include "ash/common/wm_lookup.h"
 #include "ash/common/wm_shell.h"
 #include "ash/common/wm_window.h"
@@ skipping 215 matching lines @@
   }
 
   void ExpectChildNodeRemoved(int parent_id, int node_id) {
     EXPECT_EQ(1, frontend_channel()->CountProtocolNotificationMessage(
                      base::StringPrintf(
                          "{\"method\":\"DOM.childNodeRemoved\",\"params\":{"
                          "\"parentNodeId\":%d,\"nodeId\":%d}}",
                          parent_id, node_id)));
   }
 
-  void ExpectStyleSheetChanged(int node_id) {
-    EXPECT_EQ(1, frontend_channel()->CountProtocolNotificationMessage(
-                     base::StringPrintf(
-                         "{\"method\":\"CSS.styleSheetChanged\",\"params\":{"
-                         "\"styleSheetId\":\"%d\"}}",
-                         node_id)));
+  int GetStyleSheetChangedCount(int node_id) {
+    return frontend_channel()->CountProtocolNotificationMessage(
+        base::StringPrintf("{\"method\":\"CSS.styleSheetChanged\",\"params\":{"
+                           "\"styleSheetId\":\"%d\"}}",
+                           node_id));
   }
 
   void CompareNodeBounds(DOM::Node* node, const gfx::Rect& bounds) {
     Maybe<CSS::CSSStyle> styles;
     css_agent_->getMatchedStylesForNode(node->getNodeId(), &styles);
     ASSERT_TRUE(styles.isJust());
     Array<CSS::CSSProperty>* properties = styles.fromJust()->getCssProperties();
     EXPECT_EQ(bounds.height(), GetPropertyByName("height", properties));
     EXPECT_EQ(bounds.width(), GetPropertyByName("width", properties));
     EXPECT_EQ(bounds.x(), GetPropertyByName("x", properties));
@@ skipping 413 matching lines @@
 
   CompareNodeBounds(parent_node, widget_bounds);
   CompareNodeBounds(parent_children->get(1), window_bounds);
   CompareNodeBounds(parent_children->get(0)->getChildren(nullptr)->get(0),
                     view_bounds);
 }
 
 TEST_F(AshDevToolsTest, WindowWidgetViewStyleSheetChanged) {
   std::unique_ptr<views::Widget> widget(
       CreateTestWidget(gfx::Rect(1, 1, 1, 1)));
-  WmWindow* parent_window = WmLookup::Get()->GetWindowForWidget(widget.get());
-  std::unique_ptr<WindowOwner> child_owner(CreateChildWindow(parent_window));
-  WmWindow* window = child_owner->window();
+  WmWindow* widget_window = WmLookup::Get()->GetWindowForWidget(widget.get());
+  std::unique_ptr<WindowOwner> child_owner(CreateChildWindow(widget_window));
+  WmWindow* child = child_owner->window();
 
   std::unique_ptr<ui::devtools::protocol::DOM::Node> root;
   dom_agent()->getDocument(&root);
 
-  gfx::Rect window_bounds(2, 2, 3, 3);
-  gfx::Rect widget_bounds(10, 10, 5, 6);
+  gfx::Rect child_bounds(2, 2, 3, 3);
+  gfx::Rect widget_bounds(10, 10, 150, 160);

[sky, 2017/02/22 20:44:51]

This and increasing the expected count to 2 (line 696 new) are the only real
changes here.

   gfx::Rect view_bounds(4, 4, 3, 3);
-  window->SetBounds(window_bounds);
+  child->SetBounds(child_bounds);
   widget->SetBounds(widget_bounds);
   widget->GetRootView()->SetBoundsRect(view_bounds);
 
-  DOM::Node* parent_node = FindInRoot(parent_window, root.get());
-  ASSERT_TRUE(parent_node);
-  Array<DOM::Node>* parent_children = parent_node->getChildren(nullptr);
-  ASSERT_TRUE(parent_children);
+  DOM::Node* widget_node = FindInRoot(widget_window, root.get());
+  ASSERT_TRUE(widget_node);
+  Array<DOM::Node>* widget_node_children = widget_node->getChildren(nullptr);
+  ASSERT_TRUE(widget_node_children);
 
-  ExpectStyleSheetChanged(parent_node->getNodeId());
-  ExpectStyleSheetChanged(parent_children->get(1)->getNodeId());
-  ExpectStyleSheetChanged(
-      parent_children->get(0)->getChildren(nullptr)->get(0)->getNodeId());
+  EXPECT_EQ(1, GetStyleSheetChangedCount(widget_node->getNodeId()));
+  EXPECT_EQ(
+      1, GetStyleSheetChangedCount(widget_node_children->get(1)->getNodeId()));
+  EXPECT_EQ(2,
+            GetStyleSheetChangedCount(widget_node_children->get(0)
+                                          ->getChildren(nullptr)
+                                          ->get(0)
+                                          ->getNodeId()));
 }
 
 TEST_F(AshDevToolsTest, WindowWidgetViewSetStyleText) {
   std::unique_ptr<views::Widget> widget(
       CreateTestWidget(gfx::Rect(0, 0, 400, 400)));
   WmWindow* parent_window = WmLookup::Get()->GetWindowForWidget(widget.get());
   std::unique_ptr<WindowOwner> child_owner(CreateChildWindow(parent_window));
   WmWindow* window = child_owner->window();
   views::View* root_view = widget->GetRootView();
 
@@ skipping 46 matching lines @@
   EXPECT_EQ(gfx::Rect(25, 35, 45, 20), root_view->bounds());  // Not changed
 
   SetStyleTexts(root_view_node, "\nheight: 73;\n  ", true);
   EXPECT_EQ(gfx::Rect(25, 35, 45, 73), root_view->bounds());
 
   SetStyleTexts(root_view_node, "\nx: 10; y: 23; width: 52;\n  ", true);
   EXPECT_EQ(gfx::Rect(10, 23, 52, 73), root_view->bounds());
 }
 
 }  // namespace ash