Add NTPViewController to Showcase.

Add NTPViewController to Showcase.

BUG=none
R=justincohen@chromium.org

Review-Url: https://codereview.chromium.org/2712743005
Cr-Commit-Position: refs/heads/master@{#464477}
Committed: https://chromium.googlesource.com/chromium/src/+/fde00dd77cc64eaf7080bd1a693ff89a64e54cac

[lpromero, 2017-02-24 10:19:00]

https://codereview.chromium.org/2712743005/diff/20001/ios/showcase/ntp/sc_ntp...
File ios/showcase/ntp/sc_ntp_coordinator.mm (right):

https://codereview.chromium.org/2712743005/diff/20001/ios/showcase/ntp/sc_ntp...
ios/showcase/ntp/sc_ntp_coordinator.mm:18: UIViewController* ntp =
[[NTPViewController alloc] init];
This is where you setup ntp with whatever you want (mock data, etc.). Since
NTPViewController is more a container than a content view controller, there
might not be a lot? Maybe a fake google_landing_controller? Like a wireframe
controller that only shows a crossed box:
http://www.experienceux.co.uk/wp-content/uploads/2015/06/wireframe_example_la...

[lpromero, 2017-03-23 11:35:10]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 11:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 12:45:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 12:45:42]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-03-23 15:54:43]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 15:55:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:58:17]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-03-23 17:54:04]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 17:54:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:09:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:09:35]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-04-06 09:13:53]

Should I land this?

[justincohen, 2017-04-06 19:30:22]

https://codereview.chromium.org/2712743005/diff/100001/ios/showcase/ntp/sc_nt...
File ios/showcase/ntp/sc_ntp_coordinator.mm (right):

https://codereview.chromium.org/2712743005/diff/100001/ios/showcase/ntp/sc_nt...
ios/showcase/ntp/sc_ntp_coordinator.mm:18: UIViewController* ntp =
[[NTPViewController alloc] init];
I thought showcase doesn't have an NTP, just a chrome home concept?

[lpromero, 2017-04-13 16:44:38]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 16:45:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-04-13 16:46:27]

Some next steps:
- have the NTP content view controllers shown in a different page of Showcase
- have EG tests

https://codereview.chromium.org/2712743005/diff/100001/ios/showcase/ntp/sc_nt...
File ios/showcase/ntp/sc_ntp_coordinator.mm (right):

https://codereview.chromium.org/2712743005/diff/100001/ios/showcase/ntp/sc_nt...
ios/showcase/ntp/sc_ntp_coordinator.mm:18: UIViewController* ntp =
[[NTPViewController alloc] init];
On 2017/04/06 19:30:22, justincohen wrote:
> I thought showcase doesn't have an NTP, just a chrome home concept?

Showcase is really just a portfolio of UI elements, it can have everything we
want :)
I think having the controller in Showcase is a good exercise and check that it
doesn't rely on non-UI layer classes.

[justincohen, 2017-04-13 16:50:32]

Ah, in that case in theory this is fine, although I don't think this compiles
anymore.

[justincohen, 2017-04-13 16:52:22]

LGTM

[lpromero, 2017-04-13 17:04:28]

The CQ bit was unchecked by lpromero@chromium.org

[lpromero, 2017-04-13 17:04:57]

Thanks@

https://codereview.chromium.org/2712743005/diff/120001/ios/showcase/tab_grid/...
File ios/showcase/tab_grid/sc_tab_grid_coordinator.mm (right):

https://codereview.chromium.org/2712743005/diff/120001/ios/showcase/tab_grid/...
ios/showcase/tab_grid/sc_tab_grid_coordinator.mm:8: #import
"ios/clean/chrome/browser/ui/commands/settings_commands.h"
I am moving this in its own CL as this fixes a Showcase issue.

[lpromero, 2017-04-13 17:07:24]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 17:08:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-04-13 17:26:27]

The CQ bit was unchecked by lpromero@chromium.org

[lpromero, 2017-04-13 17:26:34]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-04-13 17:26:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/2712743005/#ps140001
(title: "Rebased")

[commit-bot: I haz the power, 2017-04-13 17:27:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 18:44:37]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1492104394734810,
"parent_rev": "f925a21a93ff3fb173fcd9bca9146ad3b002083a", "commit_rev":
"fde00dd77cc64eaf7080bd1a693ff89a64e54cac"}

[commit-bot: I haz the power, 2017-04-13 18:45:35]

Description was changed from

==========
Add NTPViewController to Showcase.

BUG=none
R=justincohen@chromium.org
==========

to

==========
Add NTPViewController to Showcase.

BUG=none
R=justincohen@chromium.org

Review-Url: https://codereview.chromium.org/2712743005
Cr-Commit-Position: refs/heads/master@{#464477}
Committed:
https://chromium.googlesource.com/chromium/src/+/fde00dd77cc64eaf7080bd1a693f...
==========

[commit-bot: I haz the power, 2017-04-13 18:45:36]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/fde00dd77cc64eaf7080bd1a693f...