Fix Showcase Settings commands.

Fix Showcase Settings commands.

The protocol was only forward declared in Showcase, never conformed to
formally (ProtocolAlerter does runtime introspection, not real
conformance).

BUG=none
R=sczs@chromium.org,edchin@chromium.org
TEST=Launch Showcase > Tab Grid > Hit the vertical dots button. It
should show an alert and not crash.

Review-Url: https://codereview.chromium.org/2814413002
Cr-Commit-Position: refs/heads/master@{#464449}
Committed: https://chromium.googlesource.com/chromium/src/+/b1267c495884cb9950558f2014633fcf822c7c59

[lpromero, 2017-04-13 16:59:24]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 16:59:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-04-13 17:00:19]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 17:00:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sczs, 2017-04-13 17:09:10]

lgtm

[lpromero, 2017-04-13 17:10:54]

The CQ bit was unchecked by lpromero@chromium.org

[lpromero, 2017-04-13 17:10:56]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2017-04-13 17:11:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 17:22:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492103456273150,
"parent_rev": "4e8cac4101f13be9f86b455f06ec7b46fc707e93", "commit_rev":
"b1267c495884cb9950558f2014633fcf822c7c59"}

[commit-bot: I haz the power, 2017-04-13 17:23:13]

Description was changed from

==========
Fix Showcase Settings commands.

The protocol was only forward declared in Showcase, never conformed to
formally (ProtocolAlerter does runtime introspection, not real
conformance).

BUG=none
R=sczs@chromium.org,edchin@chromium.org
TEST=Launch Showcase > Tab Grid > Hit the vertical dots button. It
should show an alert and not crash.
==========

to

==========
Fix Showcase Settings commands.

The protocol was only forward declared in Showcase, never conformed to
formally (ProtocolAlerter does runtime introspection, not real
conformance).

BUG=none
R=sczs@chromium.org,edchin@chromium.org
TEST=Launch Showcase > Tab Grid > Hit the vertical dots button. It
should show an alert and not crash.

Review-Url: https://codereview.chromium.org/2814413002
Cr-Commit-Position: refs/heads/master@{#464449}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1267c495884cb9950558f201463...
==========

[commit-bot: I haz the power, 2017-04-13 17:23:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b1267c495884cb9950558f201463...