Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2712713004: service worker: Remove extraneous FetchEventPreloadHandle::New() call (Closed)

Created:
3 years, 10 months ago by falken
Modified:
3 years, 10 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Remove extraneous FetchEventPreloadHandle::New() call I'm guessing this is redundant the New() call further down the function. BUG=649558 Review-Url: https://codereview.chromium.org/2712713004 Cr-Commit-Position: refs/heads/master@{#452492} Committed: https://chromium.googlesource.com/chromium/src/+/2d44c8d6fe9966f4ab98e41592fe66ee4fe6f94d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
falken
is this right?
3 years, 10 months ago (2017-02-23 08:42:13 UTC) #2
horo
lgtm Thank you.
3 years, 10 months ago (2017-02-23 13:36:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712713004/1
3 years, 10 months ago (2017-02-23 14:08:15 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 15:34:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d44c8d6fe9966f4ab98e41592fe...

Powered by Google App Engine
This is Rietveld 408576698