Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2712713004: service worker: Remove extraneous FetchEventPreloadHandle::New() call (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_fetch_dispatcher.h" 5 #include "content/browser/service_worker/service_worker_fetch_dispatcher.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 return false; 535 return false;
536 } 536 }
537 537
538 DCHECK(!url_loader_assets_); 538 DCHECK(!url_loader_assets_);
539 539
540 mojom::URLLoaderFactoryPtr url_loader_factory; 540 mojom::URLLoaderFactoryPtr url_loader_factory;
541 URLLoaderFactoryImpl::Create( 541 URLLoaderFactoryImpl::Create(
542 ResourceRequesterInfo::CreateForNavigationPreload(requester_info), 542 ResourceRequesterInfo::CreateForNavigationPreload(requester_info),
543 mojo::MakeRequest(&url_loader_factory)); 543 mojo::MakeRequest(&url_loader_factory));
544 544
545 preload_handle_ = mojom::FetchEventPreloadHandle::New();
546
547 ResourceRequest request; 545 ResourceRequest request;
548 request.method = original_request->method(); 546 request.method = original_request->method();
549 request.url = original_request->url(); 547 request.url = original_request->url();
550 // TODO(horo): Set first_party_for_cookies to support Same-site Cookies. 548 // TODO(horo): Set first_party_for_cookies to support Same-site Cookies.
551 request.request_initiator = original_request->initiator().has_value() 549 request.request_initiator = original_request->initiator().has_value()
552 ? original_request->initiator() 550 ? original_request->initiator()
553 : url::Origin(original_request->url()); 551 : url::Origin(original_request->url());
554 request.referrer = GURL(original_request->referrer()); 552 request.referrer = GURL(original_request->referrer());
555 request.referrer_policy = original_info->GetReferrerPolicy(); 553 request.referrer_policy = original_info->GetReferrerPolicy();
556 request.visibility_state = original_info->GetVisibilityState(); 554 request.visibility_state = original_info->GetVisibilityState();
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 ServiceWorkerVersion* version, 613 ServiceWorkerVersion* version,
616 int event_finish_id, 614 int event_finish_id,
617 scoped_refptr<URLLoaderAssets> url_loader_assets, 615 scoped_refptr<URLLoaderAssets> url_loader_assets,
618 ServiceWorkerStatusCode status, 616 ServiceWorkerStatusCode status,
619 base::Time dispatch_event_time) { 617 base::Time dispatch_event_time) {
620 version->FinishRequest(event_finish_id, status != SERVICE_WORKER_ERROR_ABORT, 618 version->FinishRequest(event_finish_id, status != SERVICE_WORKER_ERROR_ABORT,
621 dispatch_event_time); 619 dispatch_event_time);
622 } 620 }
623 621
624 } // namespace content 622 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698