Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2712583002: Revert incognito and theme inactive color changes. (Closed)

Created:
3 years, 10 months ago by Bret
Modified:
3 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert incognito and theme inactive color changes. Partial revert of crrev.com/2541873004. We're not happy with the colors and we don't want to ship them in 57. But we're keeping the default non-incognito/inactive color change to #F5F5F5 because it dramatically increases contrast with the active frame. TBR=estade@chromium.org BUG=645682, 677172 Review-Url: https://codereview.chromium.org/2663363002 Cr-Commit-Position: refs/heads/master@{#448752} (cherry picked from commit af5bd1316ab3fd3054d08471c0a25b4b7c66cf9c) Review-Url: https://codereview.chromium.org/2712583002 . Cr-Commit-Position: refs/branch-heads/2987@{#630} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/d542e5990f46859423784528739ea9b5e406b3c8

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/themes/browser_theme_pack.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_properties.cc View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Bret
3 years, 10 months ago (2017-02-21 23:54:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d542e5990f46859423784528739ea9b5e406b3c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698