Revert incognito and theme inactive color changes.

Revert incognito and theme inactive color changes.

Partial revert of crrev.com/2541873004. We're not happy with the colors
and we don't want to ship them in 57. But we're keeping the default
non-incognito/inactive color change to #F5F5F5 because it dramatically
increases contrast with the active frame.

BUG=645682, 677172
Review-Url: https://codereview.chromium.org/2663363002
Cr-Commit-Position: refs/heads/master@{#448752}
Committed: https://chromium.googlesource.com/chromium/src/+/af5bd1316ab3fd3054d08471c0a25b4b7c66cf9c

[Bret, 2017-02-01 01:46:37]

Description was changed from

==========
Revert incognito and theme inactive color changes.

Partial revert of crrev.com/2541873004. We're not happy with the colors
and we don't want to ship them in 57. But we're keeping the default
non-incognito/inactive color change to #F5F5F5 because it dramatically
increases contrast with the active frame.

BUG=645682,677172
==========

to

==========
Revert incognito and theme inactive color changes.

Partial revert of crrev.com/2541873004. We're not happy with the colors
and we don't want to ship them in 57. But we're keeping the default
non-incognito/inactive color change to #F5F5F5 because it dramatically
increases contrast with the active frame.

BUG=645682,677172
==========

[Bret, 2017-02-01 01:46:38]

bsep@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2017-02-01 01:49:33]

https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
chrome/browser/themes/browser_theme_pack.cc:51: const int kThemePackVersion =
44;
think you need to bump this to 46

[Bret, 2017-02-01 02:12:36]

https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
chrome/browser/themes/browser_theme_pack.cc:51: const int kThemePackVersion =
44;
On 2017/02/01 01:49:33, Evan Stade wrote:
> think you need to bump this to 46

Hmm... I figured that since this is just used to decide when to recreate theme
packs and I changed everything theme-related back to how it was for version 44
that it was okay to revert to version 44 too. But if you still don't think it's
a good idea I'll bump it to 46.

[Bret, 2017-02-03 20:13:13]

https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
chrome/browser/themes/browser_theme_pack.cc:51: const int kThemePackVersion =
44;
On 2017/02/01 02:12:35, Bret Sepulveda wrote:
> On 2017/02/01 01:49:33, Evan Stade wrote:
> > think you need to bump this to 46
> 
> Hmm... I figured that since this is just used to decide when to recreate theme
> packs and I changed everything theme-related back to how it was for version 44
> that it was okay to revert to version 44 too. But if you still don't think
it's
> a good idea I'll bump it to 46.

Someone bumped this to 46 already, so never mind. Changed to 47.

[Bret, 2017-02-07 20:38:31]

On 2017/02/03 20:13:13, Bret Sepulveda wrote:
>
https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
> File chrome/browser/themes/browser_theme_pack.cc (right):
> 
>
https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
> chrome/browser/themes/browser_theme_pack.cc:51: const int kThemePackVersion =
> 44;
> On 2017/02/01 02:12:35, Bret Sepulveda wrote:
> > On 2017/02/01 01:49:33, Evan Stade wrote:
> > > think you need to bump this to 46
> > 
> > Hmm... I figured that since this is just used to decide when to recreate
theme
> > packs and I changed everything theme-related back to how it was for version
44
> > that it was okay to revert to version 44 too. But if you still don't think
> it's
> > a good idea I'll bump it to 46.
> 
> Someone bumped this to 46 already, so never mind. Changed to 47.

Ping?

[Evan Stade, 2017-02-07 21:13:28]

On 2017/02/07 20:38:31, Bret Sepulveda wrote:
> On 2017/02/03 20:13:13, Bret Sepulveda wrote:
> >
>
https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
> > File chrome/browser/themes/browser_theme_pack.cc (right):
> > 
> >
>
https://codereview.chromium.org/2663363002/diff/1/chrome/browser/themes/brows...
> > chrome/browser/themes/browser_theme_pack.cc:51: const int kThemePackVersion
=
> > 44;
> > On 2017/02/01 02:12:35, Bret Sepulveda wrote:
> > > On 2017/02/01 01:49:33, Evan Stade wrote:
> > > > think you need to bump this to 46
> > > 
> > > Hmm... I figured that since this is just used to decide when to recreate
> theme
> > > packs and I changed everything theme-related back to how it was for
version
> 44
> > > that it was okay to revert to version 44 too. But if you still don't think
> > it's
> > > a good idea I'll bump it to 46.
> > 
> > Someone bumped this to 46 already, so never mind. Changed to 47.
> 
> Ping?

Sorry! LGTM

You need to change the version because if someone used a version with your
changes then you revert the changes they need to rebuild the theme pack.

[Bret, 2017-02-07 21:21:10]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-02-07 21:22:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 22:40:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486502470116140,
"parent_rev": "7f3c2b8170c9058511d39135cfa1ff7cf0c9a668", "commit_rev":
"af5bd1316ab3fd3054d08471c0a25b4b7c66cf9c"}

[commit-bot: I haz the power, 2017-02-07 22:41:20]

Description was changed from

==========
Revert incognito and theme inactive color changes.

Partial revert of crrev.com/2541873004. We're not happy with the colors
and we don't want to ship them in 57. But we're keeping the default
non-incognito/inactive color change to #F5F5F5 because it dramatically
increases contrast with the active frame.

BUG=645682,677172
==========

to

==========
Revert incognito and theme inactive color changes.

Partial revert of crrev.com/2541873004. We're not happy with the colors
and we don't want to ship them in 57. But we're keeping the default
non-incognito/inactive color change to #F5F5F5 because it dramatically
increases contrast with the active frame.

BUG=645682,677172

Review-Url: https://codereview.chromium.org/2663363002
Cr-Commit-Position: refs/heads/master@{#448752}
Committed:
https://chromium.googlesource.com/chromium/src/+/af5bd1316ab3fd3054d08471c0a2...
==========

[commit-bot: I haz the power, 2017-02-07 22:41:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/af5bd1316ab3fd3054d08471c0a2...