Allow building the dump_syms tool on Windows

Allow building the dump_syms tool on Windows

The Windows target was not ported from gyp, until now.
We're building dump_syms on Windows in Opera so I though I'd share the patch.

BUG=245456
Review-Url: https://codereview.chromium.org/2712423002
Cr-Commit-Position: refs/heads/master@{#458759}
Committed: https://chromium.googlesource.com/chromium/src/+/143d45a4d37530b757f17f9c308412064c7d053e

[mpawlowski, 2017-02-27 07:22:39]

Description was changed from

==========
Allow building the dump_syms tool on Windows

The Windows target was not ported from gyp, until now.

BUG=245456
==========

to

==========
Allow building the dump_syms tool on Windows

The Windows target was not ported from gyp, until now.
We're building dump_syms on Windows in Opera so I though I'd share the patch.

BUG=245456
==========

[mpawlowski, 2017-02-27 07:22:39]

mpawlowski@opera.com changed reviewers:
+ mark@chromium.org, thestig@chromium.org

[mpawlowski, 2017-02-27 07:24:54]

Chosen reviewers from the OWNERS file, hope it's up to date

[Mark Mentovai, 2017-02-27 13:47:15]

mark@chromium.org changed reviewers:
+ scottmg@chromium.org

[Mark Mentovai, 2017-02-27 13:47:15]

I think this is right, but Scott built dump_syms most recently (as in last
week), so +him.

It’d also be nice to have a gn target for symupload in here.

[mpawlowski, 2017-02-27 13:53:37]

On 2017/02/27 13:47:15, Mark Mentovai wrote:
> I think this is right, but Scott built dump_syms most recently (as in last
> week), so +him.
> 
> It’d also be nice to have a gn target for symupload in here.

We don't happen to use symupload (on any platform) so we don't have a target
made for it, sorry.

[scottmg, 2017-02-27 18:32:43]

lgtm

fwiw, rolling breakpad made a horrible mess of symbols for our crash server over
the weekend.

I'm not sure yet if this was because I built dump_syms incorrectly, or if the
code's just busted in some way I didn't understand though.

[scottmg, 2017-02-27 18:39:18]

Siggi suggested one plausible reason for why things failed horribly, which is
that I built using 2015, but the 2015 DIA DLL isn't registered on the bots.

A build via this CL would also be broken in the same way then.

I'm not sure how we load that DLL, I'll have a look into that and maybe we can
avoid needing registration entirely. At a minimum, I'll try to make it fail
harder.

[scottmg, 2017-02-27 19:26:17]

On 2017/02/27 18:39:18, scottmg wrote:
> Siggi suggested one plausible reason for why things failed horribly, which is
> that I built using 2015, but the 2015 DIA DLL isn't registered on the bots.
> 
> A build via this CL would also be broken in the same way then.
> 
> I'm not sure how we load that DLL, I'll have a look into that and maybe we can
> avoid needing registration entirely. At a minimum, I'll try to make it fail
> harder.

I filed https://crbug.com/696671. Could you put a TODO(scottmg) in this build
target with a link to that bug so that Chrome-people know that they might break
things for now?

[mpawlowski, 2017-02-28 07:39:18]

The CQ bit was checked by mpawlowski@opera.com

[mpawlowski, 2017-02-28 07:39:18]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2712423002/#ps20001
(title: "Added TODO")

[commit-bot: I haz the power, 2017-02-28 07:39:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 07:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 07:47:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mpawlowski, 2017-02-28 10:09:51]

On 2017/02/28 07:47:30, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Oh, clicked Commit without getting an LGTM for the #TODO :)

[Mark Mentovai, 2017-02-28 12:08:56]

LGTM & CQ

[Mark Mentovai, 2017-02-28 12:09:01]

The CQ bit was checked by mark@chromium.org

[commit-bot: I haz the power, 2017-02-28 12:09:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 14:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 14:04:41]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[mpawlowski, 2017-03-01 12:08:30]

On 2017/02/28 14:04:41, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_clang on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

I've fixed the issues locally but that required changes in breakpad/src
(separate submodule). How do I submit them for review?

[Mark Mentovai, 2017-03-01 14:21:55]

On 2017/03/01 12:08:30, mpawlowski wrote:
> On 2017/02/28 14:04:41, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_clang on master.tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
> 
> I've fixed the issues locally but that required changes in breakpad/src
> (separate submodule). How do I submit them for review?

Since you've already got depot_tools installed for Chromium work, you should be
able to run "fetch breakpad" to get a Breakpad checkout suitable for
contributing the fix. "git cl upload" will get locally committed modifications
on a work branch into the code review system. Breakpad uses Gerrit, not
Rietveld, but git-cl will figure that all out and point you in the right
direction. Once it's reviewed and lands on that side, we'll need to update
Breakpad in Chrome's DEPS to be able to try this again.

[mpawlowski, 2017-03-01 14:38:14]

Okay, started https://chromium-review.googlesource.com/c/448037/

[mpawlowski, 2017-03-03 08:32:51]

So, the breakpad review is completed and it says 'merged'. When can we expect
the update in Chrome's DEPS so that we can continue with this?

[Mark Mentovai, 2017-03-03 14:23:25]

On 2017/03/03 08:32:51, mpawlowski wrote:
> So, the breakpad review is completed and it says 'merged'. When can we expect
> the update in Chrome's DEPS so that we can continue with this?

Breakpad is updated in DEPS as needed. Since it's needed for this, you can
update it here. Chrome's already on a version of Breakpad close to its master
HEAD, so it shouldn't be a tricky update.

We want 67a2f50dbfee129c46cbe26e09fdc94b0f6a80f7. It's a different hash then
you've seen because Chrome pulls from a read-only copy of Breakpad rooted at its
src directory for some not-great reason.

[mpawlowski, 2017-03-22 08:21:41]

DEPS are updated, shall we run the CQ dry run?

[Mark Mentovai, 2017-03-22 12:44:10]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 12:44:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 12:46:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 12:46:35]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mpawlowski, 2017-03-22 12:51:27]

Something's wrong and I don't understand what...

[Mark Mentovai, 2017-03-22 13:31:36]

On 2017/03/22 12:51:27, mpawlowski wrote:
> Something's wrong and I don't understand what...

Check any builder's bot_update step. It'll say that the patch to DEPS failed to
apply.

Rebase locally, re-upload, and we'll try again.

[mpawlowski, 2017-03-22 14:24:11]

Indeed, there was a conflict. Should work now...

[Mark Mentovai, 2017-03-22 14:25:33]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 14:25:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-03-22 15:23:02]

I don't think there's any reason not to land this (as opposed to just dry run).
I don't believe anything else in the build will cause it to be built or run
anyhow.

[commit-bot: I haz the power, 2017-03-22 15:34:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 15:34:52]

Dry run: This issue passed the CQ dry run.

[mpawlowski, 2017-03-22 15:35:17]

The CQ bit was checked by mpawlowski@opera.com

[mpawlowski, 2017-03-22 15:35:18]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2712423002/#ps60001
(title: "Update breakpad submodule")

[commit-bot: I haz the power, 2017-03-22 15:35:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 15:39:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490196917903290,
"parent_rev": "fb44736badf0dfb9b5a3b55ee5d1aabdeb1afb3a", "commit_rev":
"143d45a4d37530b757f17f9c308412064c7d053e"}

[commit-bot: I haz the power, 2017-03-22 15:40:16]

Description was changed from

==========
Allow building the dump_syms tool on Windows

The Windows target was not ported from gyp, until now.
We're building dump_syms on Windows in Opera so I though I'd share the patch.

BUG=245456
==========

to

==========
Allow building the dump_syms tool on Windows

The Windows target was not ported from gyp, until now.
We're building dump_syms on Windows in Opera so I though I'd share the patch.

BUG=245456

Review-Url: https://codereview.chromium.org/2712423002
Cr-Commit-Position: refs/heads/master@{#458759}
Committed:
https://chromium.googlesource.com/chromium/src/+/143d45a4d37530b757f17f9c3084...
==========

[commit-bot: I haz the power, 2017-03-22 15:40:18]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/143d45a4d37530b757f17f9c3084...