Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3210)

Unified Diff: breakpad/BUILD.gn

Issue 2712423002: Allow building the dump_syms tool on Windows (Closed)
Patch Set: Update breakpad submodule Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/BUILD.gn
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index ffe1c5d6121ac4c37412aefc5ebf19988623a791..75018f0ce6b39f44f43da8bbbd2ad0f7ddf2f955 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -10,6 +10,10 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
+if (is_win) {
+ import("//build/config/win/visual_studio_version.gni")
+}
+
config("tools_config") {
include_dirs = [
"src",
@@ -823,6 +827,48 @@ if (is_linux || is_android) {
}
}
+if (is_win) {
+ executable("dump_syms") {
+ # TODO(scottmg) using this with VS2015 may break the crash server.
+ # https://crbug.com/696671
+ include_dirs = [
+ "$visual_studio_path/DIA SDK/include",
+ "src",
+ ]
+
+ sources = [
+ "src/common/windows/dia_util.cc",
+ "src/common/windows/dia_util.h",
+ "src/common/windows/guid_string.cc",
+ "src/common/windows/guid_string.h",
+ "src/common/windows/omap.cc",
+ "src/common/windows/omap.h",
+ "src/common/windows/pdb_source_line_writer.cc",
+ "src/common/windows/pdb_source_line_writer.h",
+ "src/common/windows/string_utils-inl.h",
+ "src/common/windows/string_utils.cc",
+ "src/tools/windows/dump_syms/dump_syms.cc",
+ ]
+
+ lib_dirs = []
+ if (target_cpu == "x64") {
+ lib_dirs += [ "$visual_studio_path/DIA SDK/lib/amd64" ]
+ } else {
+ lib_dirs += [ "$visual_studio_path/DIA SDK/lib" ]
+ }
+
+ libs = [
+ "diaguids.lib",
+ "imagehlp.lib",
+ ]
+ if (is_clang) {
+ # clang complains about microsoft-specific goto extensions. Instead of
+ # rewriting decade-old, goto-ridden code, disable the warning.
+ cflags = [ "-Wno-microsoft-goto" ]
+ }
+ }
+}
+
if (is_ios) {
static_library("client") {
set_sources_assignment_filter([])
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698