Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2712343004: Tidy up instance time handling in SVGSMILElement (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up instance time handling in SVGSMILElement Merge the addBeginTime and addEndTime methods into a single method addInstanceTime (that takes a BeginOrEnd argument.) Migrate callers to the new method, getting rid of SVGSMILElement::handleConditionEvent in the process. Also inline some trivial functions in SVGAnimationElement. BUG=641437 Review-Url: https://codereview.chromium.org/2712343004 Cr-Commit-Position: refs/heads/master@{#453233} Committed: https://chromium.googlesource.com/chromium/src/+/901d1e45d6a0a49407a7e8936f6edf9b6124c260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -68 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimationElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 1 chunk +4 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h View 3 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 4 chunks +21 lines, -40 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
fs
3 years, 9 months ago (2017-02-27 12:59:04 UTC) #6
Stephen Chennney
lgtm
3 years, 9 months ago (2017-02-27 15:39:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712343004/1
3 years, 9 months ago (2017-02-27 16:28:04 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 16:34:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/901d1e45d6a0a49407a7e8936f6e...

Powered by Google App Engine
This is Rietveld 408576698