Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h

Issue 2712343004: Tidy up instance time handling in SVGSMILElement (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h
diff --git a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h
index b89f40449fe61bfe9c3d0419ddbf6ba91fe9a8e7..773552cfad08a08bc7288375e4ca2240116d3b93 100644
--- a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h
+++ b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h
@@ -127,13 +127,11 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {
DECLARE_VIRTUAL_TRACE();
protected:
- void addBeginTime(
- SMILTime eventTime,
- SMILTime endTime,
- SMILTimeWithOrigin::Origin = SMILTimeWithOrigin::ParserOrigin);
- void addEndTime(
- SMILTime eventTime,
- SMILTime endTime,
+ enum BeginOrEnd { Begin, End };
+
+ void addInstanceTime(
+ BeginOrEnd,
+ SMILTime,
SMILTimeWithOrigin::Origin = SMILTimeWithOrigin::ParserOrigin);
void setInactive() { m_activeState = Inactive; }
@@ -159,8 +157,6 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {
bool layoutObjectIsNeeded(const ComputedStyle&) override { return false; }
- enum BeginOrEnd { Begin, End };
-
SMILTime findInstanceTime(BeginOrEnd,
SMILTime minimumTime,
bool equalsMinimumOK) const;
@@ -237,9 +233,6 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {
void disconnectSyncBaseConditions();
void disconnectEventBaseConditions();
- // Event base timing
- void handleConditionEvent(Event*, Condition*);
-
void notifyDependentsIntervalChanged();
void createInstanceTimesFromSyncbase(SVGSMILElement& syncbase);
void addSyncBaseDependent(SVGSMILElement&);

Powered by Google App Engine
This is Rietveld 408576698