Add const char* overloads to blink::ExceptionState

Add const char* overloads to blink::ExceptionState

Many of the exceptions that are thrown are just string literals. Adding
a const char* overload avoids inlining calls to create a temporary
String object, reducing an official Linux x64 build by ~132 KB.

BUG=none

Review-Url: https://codereview.chromium.org/2718663004
Cr-Commit-Position: refs/heads/master@{#453085}
Committed: https://chromium.googlesource.com/chromium/src/+/9afd105871dadb8e2ff3c4996b10d2e3564b2026

[dcheng, 2017-02-25 09:15:14]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 09:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-25 09:17:20]

dcheng@chromium.org changed reviewers:
+ jbroman@chromium.org

[dcheng, 2017-02-25 09:17:20]

I have some other patches I'm trying as well to reduce it even further.

[haraken, 2017-02-25 09:20:10]

LGTM

[dcheng, 2017-02-25 09:57:54]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2017-02-25 09:57:55]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-02-25 09:57:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-25 10:18:21]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2017-02-25 10:36:34]

On 2017/02/25 10:18:21, dcheng wrote:
> The CQ bit was unchecked by mailto:dcheng@chromium.org

Oops, I noticed I made the new functions virtual by mistake. Measuring locally
and will re-CQ once the description is updated.

[dcheng, 2017-02-25 10:40:41]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 10:40:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-25 11:07:14]

On 2017/02/25 10:36:34, dcheng wrote:
> On 2017/02/25 10:18:21, dcheng wrote:
> > The CQ bit was unchecked by mailto:dcheng@chromium.org
> 
> Oops, I noticed I made the new functions virtual by mistake. Measuring locally
> and will re-CQ once the description is updated.

Turns out it didn't make much of a difference, but it doesn't hurt to remove the
virtuals. Re-CQing now.

[dcheng, 2017-02-25 11:07:17]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2017-02-25 11:07:18]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2017-02-25 11:07:20]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2718663004/#ps20001
(title: "Devirtualize")

[commit-bot: I haz the power, 2017-02-25 11:07:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 12:27:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488020838018000,
"parent_rev": "9c02e0c421a5d06d7acc5bae646c40e149b65989", "commit_rev":
"9afd105871dadb8e2ff3c4996b10d2e3564b2026"}

[commit-bot: I haz the power, 2017-02-25 12:28:24]

Description was changed from

==========
Add const char* overloads to blink::ExceptionState

Many of the exceptions that are thrown are just string literals. Adding
a const char* overload avoids inlining calls to create a temporary
String object, reducing an official Linux x64 build by ~132 KB.

BUG=none
==========

to

==========
Add const char* overloads to blink::ExceptionState

Many of the exceptions that are thrown are just string literals. Adding
a const char* overload avoids inlining calls to create a temporary
String object, reducing an official Linux x64 build by ~132 KB.

BUG=none

Review-Url: https://codereview.chromium.org/2718663004
Cr-Commit-Position: refs/heads/master@{#453085}
Committed:
https://chromium.googlesource.com/chromium/src/+/9afd105871dadb8e2ff3c4996b10...
==========

[commit-bot: I haz the power, 2017-02-25 12:28:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9afd105871dadb8e2ff3c4996b10...