Remove SingleThreadTaskRunner Dependency from TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeDe…

Remove SingleThreadTaskRunner Dependency from TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeDetach

SchedulerWorkerPoolImpl will have its SingleThreadTaskRunner support
removed.

BUG=694823
Review-Url: https://codereview.chromium.org/2712003002
Cr-Commit-Position: refs/heads/master@{#453138}
Committed: https://chromium.googlesource.com/chromium/src/+/35805e90395c7e4352c313247e5fd38c8ed3c94c

[robliao, 2017-02-23 22:37:58]

robliao@chromium.org changed reviewers:
+ fdoray@chromium.org, gab@chromium.org

[robliao, 2017-02-23 22:38:03]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 22:38:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 23:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 23:06:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[robliao, 2017-02-23 23:15:29]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 23:16:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2017-02-23 23:27:50]

On 2017/02/23 22:37:58, robliao wrote:

Well, looks like the bot's are flakier than my local setup! Let's hold off on
this one until I figure out another way.

[commit-bot: I haz the power, 2017-02-23 23:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 23:31:36]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[robliao, 2017-02-24 00:00:10]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 00:00:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2017-02-24 00:22:12]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-24 00:46:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 00:46:37]

Dry run: This issue passed the CQ dry run.

[robliao, 2017-02-24 00:53:43]

On 2017/02/23 23:27:50, robliao wrote:
> On 2017/02/23 22:37:58, robliao wrote:
> 
> Well, looks like the bot's are flakier than my local setup! Let's hold off on
> this one until I figure out another way.

Much better. Flakiness fixed! PTAL. Thanks!

[gab, 2017-02-24 16:40:22]

lgtm w/ nits

https://codereview.chromium.org/2712003002/diff/40001/base/task_scheduler/sch...
File base/task_scheduler/scheduler_worker_pool_impl_unittest.cc (right):

https://codereview.chromium.org/2712003002/diff/40001/base/task_scheduler/sch...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:743:
EXPECT_TRUE(thread_ref == PlatformThreadRef());
EXPECT_EQ

https://codereview.chromium.org/2712003002/diff/40001/base/task_scheduler/sch...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:757:
EXPECT_TRUE(thread_ref == PlatformThreadRef());
ditto

https://codereview.chromium.org/2712003002/diff/40001/base/task_scheduler/sch...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:787:
EXPECT_FALSE(thread_ref == PlatformThread::CurrentRef())
EXPECT_NE

[fdoray, 2017-02-24 16:50:34]

lgtm

[robliao, 2017-02-24 18:17:24]

https://codereview.chromium.org/2712003002/diff/40001/base/task_scheduler/sch...
File base/task_scheduler/scheduler_worker_pool_impl_unittest.cc (right):

https://codereview.chromium.org/2712003002/diff/40001/base/task_scheduler/sch...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:743:
EXPECT_TRUE(thread_ref == PlatformThreadRef());
On 2017/02/24 16:40:22, gab wrote:
> EXPECT_EQ

Done.

https://codereview.chromium.org/2712003002/diff/40001/base/task_scheduler/sch...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:757:
EXPECT_TRUE(thread_ref == PlatformThreadRef());
On 2017/02/24 16:40:22, gab wrote:
> ditto

See above.

https://codereview.chromium.org/2712003002/diff/40001/base/task_scheduler/sch...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:787:
EXPECT_FALSE(thread_ref == PlatformThread::CurrentRef())
On 2017/02/24 16:40:22, gab wrote:
> EXPECT_NE

See above.

[robliao, 2017-02-24 18:17:29]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 18:17:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 20:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:20:19]

Dry run: This issue passed the CQ dry run.

[robliao, 2017-02-27 02:18:29]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 02:18:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 02:36:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 02:36:12]

Dry run: This issue passed the CQ dry run.

[robliao, 2017-02-27 02:38:20]

The CQ bit was checked by robliao@chromium.org

[robliao, 2017-02-27 02:38:20]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
fdoray@chromium.org
Link to the patchset: https://codereview.chromium.org/2712003002/#ps60001
(title: "Add Dependency on PlatformThreadRef::opreator!= and switch to EXPECT_EQ
and EXPECT_NE")

[commit-bot: I haz the power, 2017-02-27 02:38:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 02:41:59]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488163100095340,
"parent_rev": "f82ecaeb1f5c38130c80f479c418eb21a412ab88", "commit_rev":
"35805e90395c7e4352c313247e5fd38c8ed3c94c"}

[commit-bot: I haz the power, 2017-02-27 02:42:52]

Description was changed from

==========
Remove SingleThreadTaskRunner Dependency from
TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeDetach

SchedulerWorkerPoolImpl will have its SingleThreadTaskRunner support
removed.

BUG=694823
==========

to

==========
Remove SingleThreadTaskRunner Dependency from
TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeDetach

SchedulerWorkerPoolImpl will have its SingleThreadTaskRunner support
removed.

BUG=694823

Review-Url: https://codereview.chromium.org/2712003002
Cr-Commit-Position: refs/heads/master@{#453138}
Committed:
https://chromium.googlesource.com/chromium/src/+/35805e90395c7e4352c313247e5f...
==========

[commit-bot: I haz the power, 2017-02-27 02:42:54]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/35805e90395c7e4352c313247e5f...