Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2702403014: Add operator!= to PlatformThreadRef (Closed)

Created:
3 years, 10 months ago by robliao
Modified:
3 years, 9 months ago
Reviewers:
gab
CC:
chromium-reviews, vmpstr+watch_chromium.org, fdoray
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add operator!= to PlatformThreadRef Per the C++ Style Guide: If you define an operator, also define any related operators that make sense, and make sure they are defined consistently. https://google.github.io/styleguide/cppguide.html#Operator_Overloading BUG= Review-Url: https://codereview.chromium.org/2702403014 Cr-Commit-Position: refs/heads/master@{#453137} Committed: https://chromium.googlesource.com/chromium/src/+/f82ecaeb1f5c38130c80f479c418eb21a412ab88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/threading/platform_thread.h View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
robliao
3 years, 10 months ago (2017-02-24 18:14:45 UTC) #2
gab
Thanks, lgtm
3 years, 10 months ago (2017-02-24 18:45:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702403014/1
3 years, 9 months ago (2017-02-27 00:01:12 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 02:00:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f82ecaeb1f5c38130c80f479c418...

Powered by Google App Engine
This is Rietveld 408576698