Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2711803002: Disallow 'position: sticky' on <thead> and <tr> elements. (Closed)

Created:
3 years, 10 months ago by smcgruer
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow 'position: sticky' on <thead> and <tr> elements. The implementation of in-flow positioned elements in Blink does not support <thead> and <tr> as per the CSS 2.1 spec. This makes it difficult to support position: sticky for them, so until Blink supports CSS 3 positioning we should disallow it. BUG=695179 Review-Url: https://codereview.chromium.org/2711803002 Cr-Commit-Position: refs/heads/master@{#453619} Committed: https://chromium.googlesource.com/chromium/src/+/d10f5767cbf8050a4d39a3f42306d58eab351cf7

Patch Set 1 #

Patch Set 2 : Correct layout tests #

Messages

Total messages: 26 (17 generated)
smcgruer
3 years, 10 months ago (2017-02-22 23:06:47 UTC) #9
smcgruer
3 years, 10 months ago (2017-02-22 23:06:48 UTC) #10
flackr
LGTM
3 years, 10 months ago (2017-02-22 23:18:46 UTC) #11
smcgruer
With apologies for the number of CLs today, +chrishtr for Blink OWNERS :)
3 years, 10 months ago (2017-02-22 23:21:40 UTC) #13
smcgruer
3 years, 10 months ago (2017-02-23 20:04:00 UTC) #15
smcgruer
Ping for Blink OWNERS :)
3 years, 9 months ago (2017-02-28 13:48:26 UTC) #19
rune
Looks reasonable to me, lgtm.
3 years, 9 months ago (2017-02-28 14:23:48 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711803002/20001
3 years, 9 months ago (2017-02-28 15:16:20 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 16:37:15 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d10f5767cbf8050a4d39a3f42306...

Powered by Google App Engine
This is Rietveld 408576698