Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 2711803002: Disallow 'position: sticky' on <thead> and <tr> elements. (Closed)
Patch Set: Correct layout tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-thead-top-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
index dc21e25edac0fcf4d09c08933395faf70e5057f6..98701adeb7e79253bc8b0accd4eb13715b74502b 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
@@ -339,14 +339,16 @@ static void adjustStyleForDisplay(ComputedStyle& style,
style.getWritingMode() != layoutParentStyle.getWritingMode())
style.setDisplay(EDisplay::InlineBlock);
- // After performing the display mutation, check table rows. We do not honor
- // position: relative table rows. This has been established for position:
- // relative in CSS2.1 (and caused a crash in containingBlock() on some sites).
+ // We do not honor position: relative or sticky for table rows, headers, and
+ // footers. This is correct for position: relative in CSS2.1 (and caused a
+ // crash in containingBlock() on some sites) and position: sticky is defined
+ // as following position: relative behavior for table elements. It is
+ // incorrect for CSS3.
if ((style.display() == EDisplay::TableHeaderGroup ||
style.display() == EDisplay::TableRowGroup ||
style.display() == EDisplay::TableFooterGroup ||
style.display() == EDisplay::TableRow) &&
- style.position() == EPosition::kRelative)
+ style.hasInFlowPosition())
style.setPosition(EPosition::kStatic);
// Cannot support position: sticky for table columns and column groups because
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-thead-top-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698