Support the googNoiseReduction constraint in SelectSettings for video-device capture.

Support the googNoiseReduction constraint in SelectSettings for video-device capture.

BUG=657733
Review-Url: https://codereview.chromium.org/2711783008
Cr-Commit-Position: refs/heads/master@{#453263}
Committed: https://chromium.googlesource.com/chromium/src/+/621ffb7bf396de27c23f539bb4e8214eb398356d

[Guido Urdaneta, 2017-02-24 15:59:30]

Patchset #1 (id:1) has been deleted

[Guido Urdaneta, 2017-02-24 15:59:37]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 15:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-02-24 16:23:25]

guidou@chromium.org changed reviewers:
+ hbos@chromium.org

[Guido Urdaneta, 2017-02-24 16:23:25]

Hi, PTAL

[commit-bot: I haz the power, 2017-02-24 17:01:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 17:01:56]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-02-25 11:24:22]

Patchset #1 (id:20001) has been deleted

[Guido Urdaneta, 2017-02-25 11:25:41]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 11:25:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 12:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 12:16:05]

Dry run: This issue passed the CQ dry run.

[hbos_chromium, 2017-02-27 11:57:08]

lgtm with comment about unit test addressed.

https://codereview.chromium.org/2711783008/diff/40001/content/renderer/media/...
File
content/renderer/media/media_stream_constraints_util_video_device_unittest.cc
(right):

https://codereview.chromium.org/2711783008/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_constraints_util_video_device_unittest.cc:1382:
// first set. The low-res device should be selected in that case.
With Exacts a device will satisfy the first OR the second constraint. It will
reject the second one based not only on the noise reduction being contradictory
but also based on resolution not matching the first one.

This test will be more precise with Minimums, where if it wasn't for the noise
reduction it could actually satisfy both constraints.

Then it will be forced to pick a lower resolution because the higher resolution
cannot be satisfied due to contradiction. If it wasn't for the noise reduction
it would pick the higher resolution because that satisfies both constraints and
not just the first one.

[Guido Urdaneta, 2017-02-27 17:14:21]

https://codereview.chromium.org/2711783008/diff/40001/content/renderer/media/...
File
content/renderer/media/media_stream_constraints_util_video_device_unittest.cc
(right):

https://codereview.chromium.org/2711783008/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_constraints_util_video_device_unittest.cc:1382:
// first set. The low-res device should be selected in that case.
On 2017/02/27 11:57:07, hbos_chromium wrote:
> With Exacts a device will satisfy the first OR the second constraint. It will
> reject the second one based not only on the noise reduction being
contradictory
> but also based on resolution not matching the first one.
> 
> This test will be more precise with Minimums, where if it wasn't for the noise
> reduction it could actually satisfy both constraints.
> 
> Then it will be forced to pick a lower resolution because the higher
resolution
> cannot be satisfied due to contradiction. If it wasn't for the noise reduction
> it would pick the higher resolution because that satisfies both constraints
and
> not just the first one.

Done.

[Guido Urdaneta, 2017-02-27 17:14:30]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2017-02-27 17:14:30]

The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org
Link to the patchset: https://codereview.chromium.org/2711783008/#ps60001
(title: "address hbos comments")

[commit-bot: I haz the power, 2017-02-27 17:14:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-02-27 17:16:12]

The CQ bit was unchecked by guidou@chromium.org

[Guido Urdaneta, 2017-02-27 17:20:26]

Patchset #3 (id:80001) has been deleted

[Guido Urdaneta, 2017-02-27 17:22:53]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2017-02-27 17:22:53]

The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org
Link to the patchset: https://codereview.chromium.org/2711783008/#ps100001
(title: "remove redundant braces")

[commit-bot: I haz the power, 2017-02-27 17:23:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 18:19:21]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488216173002680,
"parent_rev": "76a6942d9ee1972d4ab6676d93625774940230a4", "commit_rev":
"621ffb7bf396de27c23f539bb4e8214eb398356d"}

[commit-bot: I haz the power, 2017-02-27 18:20:00]

Description was changed from

==========
Support the googNoiseReduction constraint in SelectSettings for video-device
capture.

BUG=657733
==========

to

==========
Support the googNoiseReduction constraint in SelectSettings for video-device
capture.

BUG=657733

Review-Url: https://codereview.chromium.org/2711783008
Cr-Commit-Position: refs/heads/master@{#453263}
Committed:
https://chromium.googlesource.com/chromium/src/+/621ffb7bf396de27c23f539bb4e8...
==========

[commit-bot: I haz the power, 2017-02-27 18:20:02]

Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/621ffb7bf396de27c23f539bb4e8...