Minor refactoring of support classes for video-device constraints.

Minor refactoring of support classes for video-device constraints.

1. Replace "VideoSource" with "VideoDeviceSource" in class and struct names.
   In addition to device-capture video sources there are modules in
   preparation for content-capture video sources and video tracks.
   Since content-capture sources are also sources, the video_source name
   is more general than it should be.

2. Replace "video_source" with "video_device" in file names.
   Same reason as above. Not using "video_device_source" because it
   would result in names that are too long, resulting in #includes
   and #defines lines that have more than 80 columns.

3. Fix a minor style violation.
   The method has_value should have been HasValue since it is not exactly
   an accessor.

4. Move a few general functions to media_stream_constraints_util.h since
   they will be used by the upcoming modules.

5. Move the Settings type to the .cc file. Work with modules in follow-up CLs has shown that it is more convenient to return the result in the types that are expected by other content classes rather than introduce a new class that will need to be translated. (e.g., translating from Settings to media::VideoCaptureParams).

BUG=657733
Review-Url: https://codereview.chromium.org/2707203006
Cr-Commit-Position: refs/heads/master@{#452834}
Committed: https://chromium.googlesource.com/chromium/src/+/3badfc1687f2db393cec360febe0dbcf38522447

[Guido Urdaneta, 2017-02-23 18:20:14]

Patchset #1 (id:1) has been deleted

[Guido Urdaneta, 2017-02-23 18:20:38]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 18:21:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 18:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 18:25:00]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Guido Urdaneta, 2017-02-23 18:48:33]

Patchset #1 (id:20001) has been deleted

[Guido Urdaneta, 2017-02-23 18:49:01]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 18:49:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 20:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 20:05:01]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-02-24 09:40:16]

guidou@chromium.org changed reviewers:
+ hbos@chromium.org

[Guido Urdaneta, 2017-02-24 09:40:16]

Hi, PTAL

[hbos_chromium, 2017-02-24 11:28:57]

lgtm

https://codereview.chromium.org/2707203006/diff/60001/content/renderer/media/...
File content/renderer/media/media_stream_constraints_util_video_device.h
(right):

https://codereview.chromium.org/2707203006/diff/60001/content/renderer/media/...
content/renderer/media/media_stream_constraints_util_video_device.h:66: }
Here you use names like Width() but in VideoDeviceCaptureSourceSettings you use
names like GetWidth(). I'm OK with either but be consistent.

[Guido Urdaneta, 2017-02-24 11:54:55]

Description was changed from

==========
Minor refactoring of support classes for video-device constraints.

1. Replace "VideoSource" with "VideoDeviceSource" in class and struct names.
   In addition to device-capture video sources there are modules in
   preparation for content-capture video sources and video tracks.
   Since content-capture sources are also sources, the video_source name
   is more general than it should be.

2. Replace "video_source" with "video_device" in file names.
   Same reason as above. Not using "video_device_source" because it
   would result in names that are too long, resulting in #includes
   and #defines lines that have more than 80 columns.

3. Fix a minor style violation.
   The method has_value should have been HasValue since it is not exactly
   an accessor.

4. Move a few general functions to media_stream_constraints_util.h since
   they will be used by the upcoming modules.

BUG=657733
==========

to

==========
Minor refactoring of support classes for video-device constraints.

1. Replace "VideoSource" with "VideoDeviceSource" in class and struct names.
   In addition to device-capture video sources there are modules in
   preparation for content-capture video sources and video tracks.
   Since content-capture sources are also sources, the video_source name
   is more general than it should be.

2. Replace "video_source" with "video_device" in file names.
   Same reason as above. Not using "video_device_source" because it
   would result in names that are too long, resulting in #includes
   and #defines lines that have more than 80 columns.

3. Fix a minor style violation.
   The method has_value should have been HasValue since it is not exactly
   an accessor.

4. Move a few general functions to media_stream_constraints_util.h since
   they will be used by the upcoming modules.

5. Move the Settings type to the .cc file. Work with modules in follow-up CLs
has shown that it is more convenient to return the result in the types that are
expected by other content classes rather than introduce a new class that will
need to be translated. (e.g., translating from Settings to
media::VideoCaptureParams).

BUG=657733
==========

[Guido Urdaneta, 2017-02-24 11:56:28]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 11:56:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-02-24 13:13:44]

https://codereview.chromium.org/2707203006/diff/60001/content/renderer/media/...
File content/renderer/media/media_stream_constraints_util_video_device.h
(right):

https://codereview.chromium.org/2707203006/diff/60001/content/renderer/media/...
content/renderer/media/media_stream_constraints_util_video_device.h:66: }
On 2017/02/24 11:28:57, hbos_chromium wrote:
> Here you use names like Width() but in VideoDeviceCaptureSourceSettings you
use
> names like GetWidth(). I'm OK with either but be consistent.

As discussed offline, the Get ones are not just accessors, but also make type
transformations to be more Blink friendly. Updated the comment for Get functions
to make that more clear.

[Guido Urdaneta, 2017-02-24 13:13:57]

guidou@chromium.org changed reviewers:
+ avi@chromium.org

[commit-bot: I haz the power, 2017-02-24 13:14:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 13:14:11]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-02-24 13:14:46]

avi@: can you rs? (Feel free to look at everything, of course).

[Avi (use Gerrit), 2017-02-24 15:41:06]

lgtm

stampity stamp

[Guido Urdaneta, 2017-02-24 15:41:41]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2017-02-24 15:41:42]

The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org
Link to the patchset: https://codereview.chromium.org/2707203006/#ps80001
(title: "hbos comment + fix in accessor")

[commit-bot: I haz the power, 2017-02-24 15:42:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 15:46:40]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487950901500780,
"parent_rev": "7c787e8cafaa3b13951ce38c76e0ebefb31ff454", "commit_rev":
"3badfc1687f2db393cec360febe0dbcf38522447"}

[commit-bot: I haz the power, 2017-02-24 15:47:18]

Description was changed from

==========
Minor refactoring of support classes for video-device constraints.

1. Replace "VideoSource" with "VideoDeviceSource" in class and struct names.
   In addition to device-capture video sources there are modules in
   preparation for content-capture video sources and video tracks.
   Since content-capture sources are also sources, the video_source name
   is more general than it should be.

2. Replace "video_source" with "video_device" in file names.
   Same reason as above. Not using "video_device_source" because it
   would result in names that are too long, resulting in #includes
   and #defines lines that have more than 80 columns.

3. Fix a minor style violation.
   The method has_value should have been HasValue since it is not exactly
   an accessor.

4. Move a few general functions to media_stream_constraints_util.h since
   they will be used by the upcoming modules.

5. Move the Settings type to the .cc file. Work with modules in follow-up CLs
has shown that it is more convenient to return the result in the types that are
expected by other content classes rather than introduce a new class that will
need to be translated. (e.g., translating from Settings to
media::VideoCaptureParams).

BUG=657733
==========

to

==========
Minor refactoring of support classes for video-device constraints.

1. Replace "VideoSource" with "VideoDeviceSource" in class and struct names.
   In addition to device-capture video sources there are modules in
   preparation for content-capture video sources and video tracks.
   Since content-capture sources are also sources, the video_source name
   is more general than it should be.

2. Replace "video_source" with "video_device" in file names.
   Same reason as above. Not using "video_device_source" because it
   would result in names that are too long, resulting in #includes
   and #defines lines that have more than 80 columns.

3. Fix a minor style violation.
   The method has_value should have been HasValue since it is not exactly
   an accessor.

4. Move a few general functions to media_stream_constraints_util.h since
   they will be used by the upcoming modules.

5. Move the Settings type to the .cc file. Work with modules in follow-up CLs
has shown that it is more convenient to return the result in the types that are
expected by other content classes rather than introduce a new class that will
need to be translated. (e.g., translating from Settings to
media::VideoCaptureParams).

BUG=657733

Review-Url: https://codereview.chromium.org/2707203006
Cr-Commit-Position: refs/heads/master@{#452834}
Committed:
https://chromium.googlesource.com/chromium/src/+/3badfc1687f2db393cec360febe0...
==========

[commit-bot: I haz the power, 2017-02-24 15:47:19]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3badfc1687f2db393cec360febe0...