Move the WebGL DrawBuffers support check to the command buffer service.

Move the WebGL DrawBuffers support check to the command buffer service.

BUG=693233
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2711783003
Cr-Commit-Position: refs/heads/master@{#453247}
Committed: https://chromium.googlesource.com/chromium/src/+/3b9d2510e14348d81ca532a5abe7b5cfc7d011d5

[Geoff Lang, 2017-02-22 19:21:23]

Description was changed from

==========
Move the WebGL DrawBuffers support check to the command buffer service.

BUG=693233
==========

to

==========
Move the WebGL DrawBuffers support check to the command buffer service.

BUG=693233
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-22 19:21:33]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 19:22:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 19:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 19:59:24]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Geoff Lang, 2017-02-22 21:26:32]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 21:27:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2017-02-22 22:05:46]

geofflang@chromium.org changed reviewers:
+ zmo@chromium.org

[Geoff Lang, 2017-02-22 22:05:46]

PTAL

[commit-bot: I haz the power, 2017-02-22 23:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 23:18:50]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2017-02-23 00:12:43]

+kbr

LGTM if the answer to my question is yes

https://codereview.chromium.org/2711783003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2711783003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:133: glTexImage2D(GL_TEXTURE_2D, 0,
GL_DEPTH_STENCIL, 1, 1, 0, GL_DEPTH_STENCIL,
Juts want to make sure this (unsized internal format) gets translated before
sending down to the driver (in the binding)

I am not sure if the translation happens in command buffer or in the binding. 
The blink side code goes through both and now we only go through the binding.

https://codereview.chromium.org/2711783003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:141: glTexImage2D(GL_TEXTURE_2D, 0,
GL_DEPTH_COMPONENT, 1, 1, 0,
Same here.

[Ken Russell (switch to Gerrit), 2017-02-23 01:46:25]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-02-23 01:46:26]

https://codereview.chromium.org/2711783003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2711783003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:133: glTexImage2D(GL_TEXTURE_2D, 0,
GL_DEPTH_STENCIL, 1, 1, 0, GL_DEPTH_STENCIL,
On 2017/02/23 00:12:43, Zhenyao Mo wrote:
> Juts want to make sure this (unsized internal format) gets translated before
> sending down to the driver (in the binding)
> 
> I am not sure if the translation happens in command buffer or in the binding. 
> The blink side code goes through both and now we only go through the binding.

I don't remember exactly at this point -- but grepping through src/ui/gl/ it
looks like no translation of this value is done in the bindings layer. So we do
need to be very careful about not generating INVALID_OPERATION errors on real ES
3.0 implementations, for example.

[Geoff Lang, 2017-02-23 19:08:28]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 19:09:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 19:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 19:40:50]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Geoff Lang, 2017-02-23 20:57:20]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 20:58:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 22:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:30:54]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2017-02-24 15:19:55]

On 2017/02/23 01:46:26, Ken Russell wrote:
>
https://codereview.chromium.org/2711783003/diff/20001/gpu/command_buffer/serv...
> File gpu/command_buffer/service/feature_info.cc (right):
> 
>
https://codereview.chromium.org/2711783003/diff/20001/gpu/command_buffer/serv...
> gpu/command_buffer/service/feature_info.cc:133: glTexImage2D(GL_TEXTURE_2D, 0,
> GL_DEPTH_STENCIL, 1, 1, 0, GL_DEPTH_STENCIL,
> On 2017/02/23 00:12:43, Zhenyao Mo wrote:
> > Juts want to make sure this (unsized internal format) gets translated before
> > sending down to the driver (in the binding)
> > 
> > I am not sure if the translation happens in command buffer or in the
binding. 
> > The blink side code goes through both and now we only go through the
binding.
> 
> I don't remember exactly at this point -- but grepping through src/ui/gl/ it
> looks like no translation of this value is done in the bindings layer. So we
do
> need to be very careful about not generating INVALID_OPERATION errors on real
ES
> 3.0 implementations, for example.

I updated the check to be safe for ES3 without the packed depth stencil
extension.

[Ken Russell (switch to Gerrit), 2017-02-27 08:20:15]

Description was changed from

==========
Move the WebGL DrawBuffers support check to the command buffer service.

BUG=693233
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move the WebGL DrawBuffers support check to the command buffer service.

BUG=693233
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-02-27 08:21:43]

Thanks Geoff.

I added master.tryserver.chromium.android:android_optional_gpu_tests_rel
manually to CQ_INCLUDE_TRYBOTS and triggered a job. Let's see how it does. That
will at least run the WebGL 1.0 conformance tests.

Yuly: we should add this bot to the various PRESUBMIT checks that run the
desktop optional GPU tryservers, assuming it's stable now. If you could verify
this and prepare a CL I'll review it.

Thanks.

[Geoff Lang, 2017-02-27 15:24:07]

On 2017/02/27 08:21:43, Ken Russell wrote:
> Thanks Geoff.
> 
> I added master.tryserver.chromium.android:android_optional_gpu_tests_rel
> manually to CQ_INCLUDE_TRYBOTS and triggered a job. Let's see how it does.
That
> will at least run the WebGL 1.0 conformance tests.
> 
> Yuly: we should add this bot to the various PRESUBMIT checks that run the
> desktop optional GPU tryservers, assuming it's stable now. If you could verify
> this and prepare a CL I'll review it.
> 
> Thanks.

Looks good.  Going to land it.

[Geoff Lang, 2017-02-27 15:24:13]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2017-02-27 15:24:14]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2711783003/#ps60001
(title: "Fix typo")

[commit-bot: I haz the power, 2017-02-27 15:24:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 17:44:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488209053308240,
"parent_rev": "c9951718824b9db9b456cd8a5ed80ee30e3f2910", "commit_rev":
"3b9d2510e14348d81ca532a5abe7b5cfc7d011d5"}

[commit-bot: I haz the power, 2017-02-27 17:45:11]

Description was changed from

==========
Move the WebGL DrawBuffers support check to the command buffer service.

BUG=693233
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Move the WebGL DrawBuffers support check to the command buffer service.

BUG=693233
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2711783003
Cr-Commit-Position: refs/heads/master@{#453247}
Committed:
https://chromium.googlesource.com/chromium/src/+/3b9d2510e14348d81ca532a5abe7...
==========

[commit-bot: I haz the power, 2017-02-27 17:45:13]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3b9d2510e14348d81ca532a5abe7...