Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2711633004: Disconnect TLS 1.3 from base::FeatureList in M56. (Closed)

Created:
3 years, 10 months ago by davidben
Modified:
3 years, 10 months ago
Reviewers:
agl
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Disconnect TLS 1.3 from base::FeatureList in M56. Finch depends on the net stack so, if it can't talk to the servers, we can't use Finch to undo a sufficiently broken change. There are enterprises with broken firewalls that break when both sides negotiate TLS 1.3. BUG=694593 R=agl@chromium.org Review-Url: https://codereview.chromium.org/2711633004 . Cr-Commit-Position: refs/branch-heads/2924@{#929} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/a0b6b5ed613b17e6e87c97d0459d21367139c343

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M components/ssl_config/ssl_config_service_manager_pref.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M components/ssl_config/ssl_config_service_manager_pref_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
davidben
3 years, 10 months ago (2017-02-22 22:26:51 UTC) #2
agl
lgtm
3 years, 10 months ago (2017-02-22 22:28:12 UTC) #3
davidben
3 years, 10 months ago (2017-02-22 22:39:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a0b6b5ed613b17e6e87c97d0459d21367139c343 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698