Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: components/ssl_config/ssl_config_service_manager_pref_unittest.cc

Issue 2711633004: Disconnect TLS 1.3 from base::FeatureList in M56. (Closed)
Patch Set: fix test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ssl_config/ssl_config_service_manager_pref.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ssl_config/ssl_config_service_manager_pref_unittest.cc
diff --git a/components/ssl_config/ssl_config_service_manager_pref_unittest.cc b/components/ssl_config/ssl_config_service_manager_pref_unittest.cc
index 675833045afa3132bd93e22f6f46ea5a0a80197f..1030f009e105a191c90a7447c7c1775b3466a67d 100644
--- a/components/ssl_config/ssl_config_service_manager_pref_unittest.cc
+++ b/components/ssl_config/ssl_config_service_manager_pref_unittest.cc
@@ -179,7 +179,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, NoSSL3) {
EXPECT_LE(net::SSL_PROTOCOL_VERSION_TLS1, ssl_config.version_min);
}
-// Tests that TLS 1.3 may be enabled via features.
+// Tests that TLS 1.3 may not be enabled via features.
TEST_F(SSLConfigServiceManagerPrefTest, TLS13Feature) {
// Toggle the feature.
base::test::ScopedFeatureList scoped_feature_list;
@@ -194,8 +194,8 @@ TEST_F(SSLConfigServiceManagerPrefTest, TLS13Feature) {
scoped_refptr<SSLConfigService> config_service(config_manager->Get());
ASSERT_TRUE(config_service.get());
- // The feature should have switched the default version_fallback_min value.
+ // The feature should still be TLS 1.2.
SSLConfig ssl_config;
config_service->GetSSLConfig(&ssl_config);
- EXPECT_EQ(net::SSL_PROTOCOL_VERSION_TLS1_3, ssl_config.version_max);
+ EXPECT_EQ(net::SSL_PROTOCOL_VERSION_TLS1_2, ssl_config.version_max);
}
« no previous file with comments | « components/ssl_config/ssl_config_service_manager_pref.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698