Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2711593006:
Report built_in_version to Omaha for Flash updates. (Closed)
DescriptionReport built_in_version to Omaha for Flash updates.
Report the built in Flash version to Omaha server for Flash updates, to
prevent a stale component update from being delivered.
BUG=695654
Review-Url: https://codereview.chromium.org/2711593006
Cr-Commit-Position: refs/heads/master@{#452919}
Committed: https://chromium.googlesource.com/chromium/src/+/421c3a3a8e73cf590f69624b15e8187a0ec413ba
Patch Set 1 #
Total comments: 2
Patch Set 2 : Report built_in_version to Omaha for Flash updates. #Messages
Total messages: 26 (17 generated)
kerrnel@chromium.org changed reviewers: + waffles@chromium.org
waffles@, PTAL. And before I forget, I tested a successful update with this change, but I should a netcat tomorrow.
The CQ bit was checked by waffles@chromium.org to run a CQ dry run
lgtm, triggered CQ dry run https://codereview.chromium.org/2711593006/diff/1/chrome/browser/component_up... File chrome/browser/component_updater/pepper_flash_component_installer.cc (right): https://codereview.chromium.org/2711593006/diff/1/chrome/browser/component_up... chrome/browser/component_updater/pepper_flash_component_installer.cc:353: attrs.insert(std::make_pair("built_in_version", flash_version)).second; Will this generated an unused variable warning in release builds?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2711593006/diff/1/chrome/browser/component_up... File chrome/browser/component_updater/pepper_flash_component_installer.cc (right): https://codereview.chromium.org/2711593006/diff/1/chrome/browser/component_up... chrome/browser/component_updater/pepper_flash_component_installer.cc:353: attrs.insert(std::make_pair("built_in_version", flash_version)).second; On 2017/02/24 18:35:51, waffles wrote: > Will this generated an unused variable warning in release builds? That's a fair point, let's do the DCHECK() directly.
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #4 (id:60001) has been deleted
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kerrnel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487970451661700,
"parent_rev": "45cf1e60f4580e225d6bdd860ddd7e23480fb678", "commit_rev":
"421c3a3a8e73cf590f69624b15e8187a0ec413ba"}
Message was sent while issue was closed.
Description was changed from ========== Report built_in_version to Omaha for Flash updates. Report the built in Flash version to Omaha server for Flash updates, to prevent a stale component update from being delivered. BUG=695654 ========== to ========== Report built_in_version to Omaha for Flash updates. Report the built in Flash version to Omaha server for Flash updates, to prevent a stale component update from being delivered. BUG=695654 Review-Url: https://codereview.chromium.org/2711593006 Cr-Commit-Position: refs/heads/master@{#452919} Committed: https://chromium.googlesource.com/chromium/src/+/421c3a3a8e73cf590f69624b15e8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as https://chromium.googlesource.com/chromium/src/+/421c3a3a8e73cf590f69624b15e8...
Message was sent while issue was closed.
On 2017/02/24 19:24:38, waffles wrote: > lgtm
Message was sent while issue was closed.
Message was sent while issue was closed.
lgtm |
