Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: chrome/browser/component_updater/pepper_flash_component_installer.cc

Issue 2711593006: Report built_in_version to Omaha for Flash updates. (Closed)
Patch Set: Report built_in_version to Omaha for Flash updates. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/pepper_flash_component_installer.cc
diff --git a/chrome/browser/component_updater/pepper_flash_component_installer.cc b/chrome/browser/component_updater/pepper_flash_component_installer.cc
index 086d405ddd8b4925401485619d0c20ab26ca184d..9f79c13686bac4173ba27df6ff813659aad7e36d 100644
--- a/chrome/browser/component_updater/pepper_flash_component_installer.cc
+++ b/chrome/browser/component_updater/pepper_flash_component_installer.cc
@@ -341,7 +341,16 @@ std::string FlashComponentInstallerTraits::GetName() const {
update_client::InstallerAttributes
FlashComponentInstallerTraits::GetInstallerAttributes() const {
- return update_client::InstallerAttributes();
+ // For Chrome OS, send the built-in flash player version to the server,
+ // otherwise it will serve component updates of outdated flash players.
+ update_client::InstallerAttributes attrs;
+#if defined(OS_CHROMEOS)
+ const std::string flash_version =
+ base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+ switches::kPpapiFlashVersion);
+ attrs["built_in_version"] = flash_version;
+#endif // #defined(OS_CHROMEOS)
+ return attrs;
}
std::vector<std::string> FlashComponentInstallerTraits::GetMimeTypes() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698