Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Issue 2711573002: cc: Fix tile priority inversion in picture layer tiling. (Closed)

Created:
3 years, 10 months ago by vmpstr
Modified:
3 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

cc: Fix tile priority inversion in picture layer tiling. This patch addresses the case where we can have a tile that is required for activation but is not in the NOW bin. This can happen since the check for whether the tile is required uses the tile's content_rect, which includes border pixels. However, the priority calculation for the tile uses TileBounds without the border pixels. This patch also moves the code to calculate required tile state from all of the different iterator call sites to MakePrioritizedTile, with an additional check to ensure that we never make a required tile outside of the now bin. R=danakj@chromium.org BUG=668892, 622080 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2651413004 Cr-Commit-Position: refs/heads/master@{#447293} (cherry picked from commit a062f034b9c367a0b3481e0390bcc0aca830b707) Review-Url: https://codereview.chromium.org/2711573002 . Cr-Commit-Position: refs/branch-heads/2987@{#620} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/050a3b4e60535623b42101cc4e269c077da721c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -16 lines) Patch
M cc/tiles/picture_layer_tiling.h View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/tiles/picture_layer_tiling.cc View 6 chunks +22 lines, -6 lines 0 comments Download
M cc/tiles/picture_layer_tiling_unittest.cc View 2 chunks +47 lines, -0 lines 0 comments Download
M cc/tiles/tiling_set_eviction_queue.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/tiles/tiling_set_raster_queue_all.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M cc/tiles/tiling_set_raster_queue_required.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vmpstr
3 years, 10 months ago (2017-02-21 20:17:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
050a3b4e60535623b42101cc4e269c077da721c7.

Powered by Google App Engine
This is Rietveld 408576698