Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: cc/tiles/tiling_set_raster_queue_all.cc

Issue 2711573002: cc: Fix tile priority inversion in picture layer tiling. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/tiles/tiling_set_eviction_queue.cc ('k') | cc/tiles/tiling_set_raster_queue_required.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/tiling_set_raster_queue_all.cc
diff --git a/cc/tiles/tiling_set_raster_queue_all.cc b/cc/tiles/tiling_set_raster_queue_all.cc
index 1d88150b21981be9c0f60948e542b23039ed848a..74bf1b2f144f806cadf802723924da96fc597f33 100644
--- a/cc/tiles/tiling_set_raster_queue_all.cc
+++ b/cc/tiles/tiling_set_raster_queue_all.cc
@@ -180,7 +180,6 @@ void TilingSetRasterQueueAll::OnePriorityRectIterator::AdvanceToNextTile(
}
Tile* tile = tiling_->TileAt(iterator->index_x(), iterator->index_y());
if (IsTileValid(tile)) {
- tiling_->UpdateRequiredStatesOnTile(tile);
current_tile_ = tiling_->MakePrioritizedTile(tile, priority_rect_type_);
break;
}
@@ -195,7 +194,6 @@ bool TilingSetRasterQueueAll::OnePriorityRectIterator::
current_tile_ = PrioritizedTile();
return false;
}
- tiling_->UpdateRequiredStatesOnTile(tile);
current_tile_ = tiling_->MakePrioritizedTile(tile, priority_rect_type_);
return true;
}
@@ -208,9 +206,9 @@ bool TilingSetRasterQueueAll::OnePriorityRectIterator::IsTileValid(
// for pending visible rect tiles as tiling iterators do not ignore those
// tiles.
if (priority_rect_type_ > PictureLayerTiling::PENDING_VISIBLE_RECT) {
- gfx::Rect tile_rect = tiling_->tiling_data()->TileBounds(
- tile->tiling_i_index(), tile->tiling_j_index());
- if (pending_visible_rect_.Intersects(tile_rect))
+ gfx::Rect tile_bounds = tiling_data_->TileBounds(tile->tiling_i_index(),
+ tile->tiling_j_index());
+ if (pending_visible_rect_.Intersects(tile_bounds))
return false;
}
return true;
« no previous file with comments | « cc/tiles/tiling_set_eviction_queue.cc ('k') | cc/tiles/tiling_set_raster_queue_required.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698