Add OffscreenCanvas to VRSource

Add OffscreenCanvas to VRSource

This change adds OffscreenCanvas to VRSource by making VRSource
into a union typedef. The internal plumbing is adjusted to handle
a union typedef.  Using an OffscreenCanvas is not functional with this
change, this is just the first step.

BUG=695497
Review-Url: https://codereview.chromium.org/2711513006
Cr-Commit-Position: refs/heads/master@{#452911}
Committed: https://chromium.googlesource.com/chromium/src/+/d726dc3033de56a1803cab8db6345de89909d506

[Justin Novosad, 2017-02-23 22:02:32]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 22:03:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2017-02-23 22:05:08]

junov@chromium.org changed reviewers:
+ bajones@chromium.org

[Justin Novosad, 2017-02-23 22:05:09]

Where do I put tests for this? I did not find any WebVR layout tests. I assume
there is another repo somewhere?

[bajones, 2017-02-23 23:30:58]

On 2017/02/23 22:05:09, Justin Novosad wrote:
> Where do I put tests for this? I did not find any WebVR layout tests. I assume
> there is another repo somewhere?

LGTM, thanks for ensuring it reports an error for now.

WebVR tests are in third_party/WebKit/LayoutTests/vr

[commit-bot: I haz the power, 2017-02-23 23:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 23:51:28]

Dry run: This issue passed the CQ dry run.

[Justin Novosad, 2017-02-23 23:58:12]

I am going to put this on hold because apparently klausw is working on this and
I want to avoid duplicating effort.

[Justin Novosad, 2017-02-23 23:58:45]

junov@chromium.org changed reviewers:
+ klausw@chromium.org

[Justin Novosad, 2017-02-23 23:58:45]

+klausw

[bajones, 2017-02-24 00:01:48]

On 2017/02/23 23:58:45, Justin Novosad wrote:
> +klausw

I believe that the work Klaus is doing that you're referring to is enabling a
path for canvas contents to be sent directly to the VR compositor, rather than
requiring that it be displayed on the page (which our current path does.)
That'll be necessary for OffscreenCanvas to work, but I don't think it overlaps
with this code.

[Justin Novosad, 2017-02-24 00:09:06]

On 2017/02/24 00:01:48, bajones wrote:
> On 2017/02/23 23:58:45, Justin Novosad wrote:
> > +klausw
> 
> I believe that the work Klaus is doing that you're referring to is enabling a
> path for canvas contents to be sent directly to the VR compositor, rather than
> requiring that it be displayed on the page (which our current path does.)
> That'll be necessary for OffscreenCanvas to work, but I don't think it
overlaps
> with this code.

Ah, there is a VR compositor?  I had an idea for a simple solution for Android
(see bug discussion).

[Justin Novosad, 2017-02-24 19:51:42]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:52:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:57:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487965902775320, "parent_rev":
"a35665af4f93f03cace29798500df6def877ba95", "commit_rev":
"d726dc3033de56a1803cab8db6345de89909d506"}

[commit-bot: I haz the power, 2017-02-24 19:58:31]

Description was changed from

==========
Add OffscreenCanvas to VRSource

This change adds OffscreenCanvas to VRSource by making VRSource
into a union typedef. The internal plumbing is adjusted to handle
a union typedef.  Using an OffscreenCanvas is not functional with this
change, this is just the first step.

BUG=695497
==========

to

==========
Add OffscreenCanvas to VRSource

This change adds OffscreenCanvas to VRSource by making VRSource
into a union typedef. The internal plumbing is adjusted to handle
a union typedef.  Using an OffscreenCanvas is not functional with this
change, this is just the first step.

BUG=695497

Review-Url: https://codereview.chromium.org/2711513006
Cr-Commit-Position: refs/heads/master@{#452911}
Committed:
https://chromium.googlesource.com/chromium/src/+/d726dc3033de56a1803cab8db634...
==========

[commit-bot: I haz the power, 2017-02-24 19:58:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d726dc3033de56a1803cab8db634...