Ensure spell checking is enabled in SpellCheckerTest

Ensure spell checking is enabled in SpellCheckerTest

This patch introduces SpellCheckTestBase, which sets up a non-empty
SpellCheckerClient that enables spell checking, so that
SpellCheckerTest can utilize this base class to correctly perform
unit tests that requires spell checking to be enabled.

The new base class will also be useful when adding unit test for
idle time spell checker.

This patch also removes spell checking related stuff from
TextFormControlElementTest, since it is leftover after we previously
moved a spell checking unit test from TextFromControlElementTest to
SpellCheckerTest.

BUG=695286
Review-Url: https://codereview.chromium.org/2711053002
Cr-Commit-Position: refs/heads/master@{#452427}
Committed: https://chromium.googlesource.com/chromium/src/+/5a9a2764673ac595836bb6cc67237ae60c3aa0bf

[Xiaocheng, 2017-02-23 02:41:09]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 02:41:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-02-23 02:45:19]

Description was changed from

==========
Ensure spell checking is enabled in SpellCheckerTest

BUG=695286
==========

to

==========
Ensure spell checking is enabled in SpellCheckerTest

This patch introduces SpellCheckTestBase, which sets up a non-empty
SpellCheckerClient that enables spell checking, so that
SpellCheckerTest can utilize this base class to correctly perform
unit tests that requires spell checking to be enabled.

The new base class will also be useful when adding unit test for
idle time spell checker.

This patch also removes spell checking related stuff from
TextFormControlElementTest, since it is leftover after we previously
moved a spell checking unit test from TextFromControlElementTest to
SpellCheckerTest.

BUG=695286
==========

[Xiaocheng, 2017-02-23 02:45:30]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2017-02-23 02:45:31]

PTAL.

[yosin_UTC9, 2017-02-23 02:52:08]

I love to have SpellCheckerTestBase.
To bold this approach, it is better to move removal of old staff in another
patch.
In this way, introduction of SpellCheckerTestBase affects core/editing only.

https://codereview.chromium.org/2711053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/TextControlElementTest.cpp (right):

https://codereview.chromium.org/2711053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/TextControlElementTest.cpp:7: #include
<memory>
Please move this removal in another patch to make introduction of
SpellCheckerTestBase, it is good, small.

[Xiaocheng, 2017-02-23 03:35:37]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 03:36:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-02-23 03:36:43]

Thanks!

https://codereview.chromium.org/2711053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/TextControlElementTest.cpp (right):

https://codereview.chromium.org/2711053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/TextControlElementTest.cpp:7: #include
<memory>
On 2017/02/23 at 02:52:08, yosin_UTC9 wrote:
> Please move this removal in another patch to make introduction of
SpellCheckerTestBase, it is good, small.

Done.

[yosin_UTC9, 2017-02-23 05:09:39]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-23 05:09:51]

lgtm

Good work!

[yosin_UTC9, 2017-02-23 05:09:53]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-23 05:10:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 07:43:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487826593650210,
"parent_rev": "592d7328de7543536c9928a5b0d11e3a97379c70", "commit_rev":
"5a9a2764673ac595836bb6cc67237ae60c3aa0bf"}

[commit-bot: I haz the power, 2017-02-23 07:44:22]

Description was changed from

==========
Ensure spell checking is enabled in SpellCheckerTest

This patch introduces SpellCheckTestBase, which sets up a non-empty
SpellCheckerClient that enables spell checking, so that
SpellCheckerTest can utilize this base class to correctly perform
unit tests that requires spell checking to be enabled.

The new base class will also be useful when adding unit test for
idle time spell checker.

This patch also removes spell checking related stuff from
TextFormControlElementTest, since it is leftover after we previously
moved a spell checking unit test from TextFromControlElementTest to
SpellCheckerTest.

BUG=695286
==========

to

==========
Ensure spell checking is enabled in SpellCheckerTest

This patch introduces SpellCheckTestBase, which sets up a non-empty
SpellCheckerClient that enables spell checking, so that
SpellCheckerTest can utilize this base class to correctly perform
unit tests that requires spell checking to be enabled.

The new base class will also be useful when adding unit test for
idle time spell checker.

This patch also removes spell checking related stuff from
TextFormControlElementTest, since it is leftover after we previously
moved a spell checking unit test from TextFromControlElementTest to
SpellCheckerTest.

BUG=695286

Review-Url: https://codereview.chromium.org/2711053002
Cr-Commit-Position: refs/heads/master@{#452427}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a9a2764673ac595836bb6cc6723...
==========

[commit-bot: I haz the power, 2017-02-23 07:44:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5a9a2764673ac595836bb6cc6723...