Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp

Issue 2711053002: Ensure spell checking is enabled in SpellCheckerTest (Closed)
Patch Set: Keep editing changes only Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellCheckTestBase.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
index 3ebd340c31e500b513e42f58fea2193c907c2a0b..f04995976e7af895203b121b5eb8d4b20c9c036e 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
@@ -4,17 +4,16 @@
#include "core/editing/spellcheck/SpellChecker.h"
-#include "core/editing/EditingTestBase.h"
#include "core/editing/Editor.h"
+#include "core/editing/spellcheck/SpellCheckTestBase.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/Settings.h"
#include "core/html/HTMLInputElement.h"
-#include "core/testing/DummyPageHolder.h"
namespace blink {
-class SpellCheckerTest : public EditingTestBase {
+class SpellCheckerTest : public SpellCheckTestBase {
protected:
int layoutCount() const { return page().frameView().layoutCount(); }
DummyPageHolder& page() const { return dummyPageHolder(); }
@@ -59,10 +58,10 @@ TEST_F(SpellCheckerTest, SpellCheckDoesNotCauseUpdateLayout) {
SelectionInDOMTree::Builder().collapse(newPosition).build());
ASSERT_EQ(3u, input->selectionStart());
- Persistent<SpellChecker> spellChecker(SpellChecker::create(page().frame()));
+ EXPECT_TRUE(frame().spellChecker().isSpellCheckingEnabled());
forceLayout();
int startCount = layoutCount();
- spellChecker->respondToChangedSelection(
+ frame().spellChecker().respondToChangedSelection(
oldSelection.start(),
FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle);
EXPECT_EQ(startCount, layoutCount());
« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellCheckTestBase.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698