Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2711003006: Remove the Physical Web SwipeRefreshWidget (Closed)

Created:
3 years, 10 months ago by cco3
Modified:
3 years, 9 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Physical Web SwipeRefreshWidget This was only useful for our ListActivity, which we removed a while ago. This change also removes some related layout files and strings that are unused. BUG=680747 Review-Url: https://codereview.chromium.org/2711003006 Cr-Commit-Position: refs/heads/master@{#453659} Committed: https://chromium.googlesource.com/chromium/src/+/ae55636c75b427588ea7361a9ab366250cb0f507

Patch Set 1 #

Total comments: 2

Patch Set 2 : git show #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -277 lines) Patch
D chrome/android/java/res/layout/physical_web_list_item_nearby_url.xml View 1 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/android/java/res/layout/physical_web_list_urls_activity.xml View 1 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/android/java/res/layout/physical_web_optin.xml View 1 1 chunk +0 lines, -95 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/physicalweb/SwipeRefreshWidget.java View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (10 generated)
cco3
3 years, 10 months ago (2017-02-23 19:50:20 UTC) #2
iankc
lgtm lgtm
3 years, 10 months ago (2017-02-23 21:57:17 UTC) #3
mattreynolds
https://codereview.chromium.org/2711003006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/SwipeRefreshWidget.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/SwipeRefreshWidget.java (left): https://codereview.chromium.org/2711003006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/SwipeRefreshWidget.java#oldcode19 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/SwipeRefreshWidget.java:19: public class SwipeRefreshWidget extends android.support.v4.widget.SwipeRefreshLayout { SwipeRefreshWidget is still ...
3 years, 10 months ago (2017-02-23 22:08:01 UTC) #4
cco3
https://codereview.chromium.org/2711003006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/SwipeRefreshWidget.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/SwipeRefreshWidget.java (left): https://codereview.chromium.org/2711003006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/SwipeRefreshWidget.java#oldcode19 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/SwipeRefreshWidget.java:19: public class SwipeRefreshWidget extends android.support.v4.widget.SwipeRefreshLayout { On 2017/02/23 22:08:01, ...
3 years, 10 months ago (2017-02-23 22:34:27 UTC) #6
mattreynolds
lgtm
3 years, 10 months ago (2017-02-24 21:48:31 UTC) #7
cco3
Here's another cleanup change, Tommy. Thanks.
3 years, 10 months ago (2017-02-24 21:50:05 UTC) #9
nyquist
awesome with cleanup! thanks! lgtm
3 years, 9 months ago (2017-02-28 06:18:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711003006/20001
3 years, 9 months ago (2017-02-28 18:03:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/374712)
3 years, 9 months ago (2017-02-28 18:10:47 UTC) #15
nyquist
twellington: PTAL //chrome/android/java/res
3 years, 9 months ago (2017-02-28 18:14:33 UTC) #17
Theresa
lgtm
3 years, 9 months ago (2017-02-28 18:19:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711003006/20001
3 years, 9 months ago (2017-02-28 18:19:59 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 19:21:20 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae55636c75b427588ea7361a9ab3...

Powered by Google App Engine
This is Rietveld 408576698