Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2711003005: Merge overflowRectForFlowThreadPortion() into flowThreadPortionOverflowRectAt(). (Closed)

Created:
3 years, 10 months ago by mstensho (USE GERRIT)
Modified:
3 years, 10 months ago
Reviewers:
eae
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge overflowRectForFlowThreadPortion() into flowThreadPortionOverflowRectAt(). No need to keep this in LayoutMultiColumnSet anymore. Also got rid of unused method LayoutMultiColumnSet::flowThreadPortionOverflowRect(). No behavior changes intended. Review-Url: https://codereview.chromium.org/2711003005 Cr-Commit-Position: refs/heads/master@{#452537} Committed: https://chromium.googlesource.com/chromium/src/+/599f8a6501faefe8a8f254ea364191e2b453ec25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -40 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +14 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 10 months ago (2017-02-23 14:47:23 UTC) #4
eae
Nice cleanup, thank you LGTM
3 years, 10 months ago (2017-02-23 15:50:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711003005/1
3 years, 10 months ago (2017-02-23 17:29:31 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 17:33:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/599f8a6501faefe8a8f254ea3641...

Powered by Google App Engine
This is Rietveld 408576698