Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

Issue 2711003005: Merge overflowRectForFlowThreadPortion() into flowThreadPortionOverflowRectAt(). (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
index b19b878a879f36805f9c17b204afd72526608803..1539e3fb17c15115155bea3bd9635d8078785f4f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
@@ -302,33 +302,6 @@ LayoutUnit LayoutMultiColumnSet::logicalBottomInFlowThread() const {
return lastFragmentainerGroup().logicalBottomInFlowThread();
}
-LayoutRect LayoutMultiColumnSet::flowThreadPortionOverflowRect() const {
- return overflowRectForFlowThreadPortion(flowThreadPortionRect(),
- !previousSiblingMultiColumnSet(),
- !nextSiblingMultiColumnSet());
-}
-
-LayoutRect LayoutMultiColumnSet::overflowRectForFlowThreadPortion(
- const LayoutRect& flowThreadPortionRect,
- bool isFirstPortion,
- bool isLastPortion) const {
- // Only clip along the block direction axis.
- LayoutRect clipRect(LayoutRect::infiniteIntRect());
-
- if (m_flowThread->isHorizontalWritingMode()) {
- if (!isFirstPortion)
- clipRect.shiftYEdgeTo(flowThreadPortionRect.y());
- if (!isLastPortion)
- clipRect.shiftMaxYEdgeTo(flowThreadPortionRect.maxY());
- return clipRect;
- }
- if (!isFirstPortion)
- clipRect.shiftXEdgeTo(flowThreadPortionRect.x());
- if (!isLastPortion)
- clipRect.shiftMaxXEdgeTo(flowThreadPortionRect.maxX());
- return clipRect;
-}
-
bool LayoutMultiColumnSet::heightIsAuto() const {
LayoutMultiColumnFlowThread* flowThread = multiColumnFlowThread();
if (!flowThread->isLayoutPagedFlowThread()) {

Powered by Google App Engine
This is Rietveld 408576698