third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 2710883002: Expand FrameSeleciton::isNone() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2710883002: Expand FrameSeleciton::isNone() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-23T16:27:43 rebase to resolve conflict with DOMSelection in r452402 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index 0d9a2295fe6db2c9a95e7ff31ba0b15200d02843..b8f758b78d64d1e58e66818c851c655141db2b9c 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -555,7 +555,10 @@ OptionalCursor EventHandler::selectAutoCursor(const HitTestResult& result,

if (m_mouseEventManager->mousePressed() &&

selectionController().mouseDownMayStartSelect() &&

!m_mouseEventManager->mouseDownMayStartDrag() &&

- !m_frame->selection().isNone() && !m_capturingMouseEventsNode) {

+ !m_frame->selection()

+ .computeVisibleSelectionInDOMTreeDeprecated()

+ .isNone() &&

+ !m_capturingMouseEventsNode) {

return iBeam;

}