third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp - Issue 2710883002: Expand FrameSeleciton::isNone() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2710883002: Expand FrameSeleciton::isNone() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-23T16:27:43 rebase to resolve conflict with DOMSelection in r452402 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

index b4cff0c3f69c229e8888bb86fa2bf2d1f5477a4d..21ce048ff2a3167b49e90e9835612d993f93580a 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

@@ -1914,7 +1914,9 @@ static bool enabledInRichlyEditableText(LocalFrame& frame,

// We should update selection to canonicalize with current layout and style,

// before accessing |FrameSelection::selection()|.

frame.selection().updateIfNeeded();

- return !frame.selection().isNone() &&

+ return !frame.selection()

+ .computeVisibleSelectionInDOMTreeDeprecated()

+ .isNone() &&

frame.selection()

.computeVisibleSelectionInDOMTreeDeprecated()

.isContentRichlyEditable() &&