third_party/WebKit/Source/core/input/EventHandlerTest.cpp - Issue 2710883002: Expand FrameSeleciton::isNone() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandlerTest.cpp

Issue 2710883002: Expand FrameSeleciton::isNone() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-23T16:27:43 rebase to resolve conflict with DOMSelection in r452402 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/EventHandlerTest.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp

index 08bd48fa748314d2039bebb84dd753831ed2259e..b6574da6b0c20d421688bfe0b21bc4551820cfbb 100644

--- a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp

@@ -382,7 +382,8 @@ TEST_F(EventHandlerTest, ClearHandleAfterTap) {

TapEventBuilder singleTapEvent(IntPoint(700, 700), 1);

document().frame()->eventHandler().handleGestureEvent(singleTapEvent);

- ASSERT_TRUE(selection().isNone());

+ ASSERT_TRUE(

+ selection().computeVisibleSelectionInDOMTreeDeprecated().isNone());

ASSERT_FALSE(selection().isHandleVisible());

}