Revert of Fix VS 2015 Update 2 specific bug

Revert of Fix VS 2015 Update 2 specific bug (patchset #3 id:40001 of https://codereview.chromium.org/1806743002/ )

Reason for revert:
This was a compiler bug workaround and the bug was fixed long ago. Note that
the #include "gpu/gpu_export.h" line that was added for the workaround is
being left in because it is now needed.

Original issue's description:
> Fix VS 2015 Update 2 specific bug
> 
> When building Chrome with VS 2015 Update 2 RC there is a compiler error:
> 
> 1>  texture_definition.cc
> 1>base/memory/ref_counted.h(414): error C2027: use of undefined type 'gpu::gles2::GLStreamTextureImage'
> 1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of 'gpu::gles2::GLStreamTextureImage'
> 1>  base/memory/ref_counted.h(413): note: while compiling class template member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T *)'
> 
> This is caused by a compiler bug, together with a type trait used in
> std::vector:
> https://twitter.com/StephanTLavavej/status/710191543840219136
> 
> A VS bug has been filed at:
> https://connect.microsoft.com/VisualStudio/feedback/details/2475971
> 
> Bug 595189 has a more minimal repro.
> 
> BUG=440500, 595189
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0
> Cr-Commit-Position: refs/heads/master@{#381640}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500, 595189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2710683014
Cr-Commit-Position: refs/heads/master@{#453704}
Committed: https://chromium.googlesource.com/chromium/src/+/39e9ce2fb50f025d2176f24e90d3f2ea15a940fd

[brucedawson, 2017-02-23 22:59:19]

Created Revert of Fix VS 2015 Update 2 specific bug

[brucedawson, 2017-02-23 23:01:20]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 23:02:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 23:27:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 23:27:53]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[brucedawson, 2017-02-24 00:44:37]

Description was changed from

==========
Revert of Fix VS 2015 Update 2 specific bug (patchset #3 id:40001 of
https://codereview.chromium.org/1806743002/ )

Reason for revert:
This was a compiler bug workaround and the bug should have been fixed long ago.

Original issue's description:
> Fix VS 2015 Update 2 specific bug
> 
> When building Chrome with VS 2015 Update 2 RC there is a compiler error:
> 
> 1>  texture_definition.cc
> 1>base/memory/ref_counted.h(414): error C2027: use of undefined type
'gpu::gles2::GLStreamTextureImage'
> 1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of
'gpu::gles2::GLStreamTextureImage'
> 1>  base/memory/ref_counted.h(413): note: while compiling class template
member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T
*)'
> 
> This is caused by a compiler bug, together with a type trait used in
> std::vector:
> https://twitter.com/StephanTLavavej/status/710191543840219136
> 
> A VS bug has been filed at:
> https://connect.microsoft.com/VisualStudio/feedback/details/2475971
> 
> Bug 595189 has a more minimal repro.
> 
> BUG=440500,595189
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0
> Cr-Commit-Position: refs/heads/master@{#381640}

TBR=piman@chromium.org,zmo@chromium.org,jmadill@chromium.org,geofflang@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,595189
==========

to

==========
Revert of Fix VS 2015 Update 2 specific bug (patchset #3 id:40001 of
https://codereview.chromium.org/1806743002/ )

Reason for revert:
This was a compiler bug workaround and the bug should have been fixed long ago.

Original issue's description:
> Fix VS 2015 Update 2 specific bug
> 
> When building Chrome with VS 2015 Update 2 RC there is a compiler error:
> 
> 1>  texture_definition.cc
> 1>base/memory/ref_counted.h(414): error C2027: use of undefined type
'gpu::gles2::GLStreamTextureImage'
> 1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of
'gpu::gles2::GLStreamTextureImage'
> 1>  base/memory/ref_counted.h(413): note: while compiling class template
member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T
*)'
> 
> This is caused by a compiler bug, together with a type trait used in
> std::vector:
> https://twitter.com/StephanTLavavej/status/710191543840219136
> 
> A VS bug has been filed at:
> https://connect.microsoft.com/VisualStudio/feedback/details/2475971
> 
> Bug 595189 has a more minimal repro.
> 
> BUG=440500,595189
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0
> Cr-Commit-Position: refs/heads/master@{#381640}

TBR=piman@chromium.org,zmo@chromium.org,jmadill@chromium.org,geofflang@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,595189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[brucedawson, 2017-02-24 00:44:44]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 00:45:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-02-24 00:45:51]

Description was changed from

==========
Revert of Fix VS 2015 Update 2 specific bug (patchset #3 id:40001 of
https://codereview.chromium.org/1806743002/ )

Reason for revert:
This was a compiler bug workaround and the bug should have been fixed long ago.

Original issue's description:
> Fix VS 2015 Update 2 specific bug
> 
> When building Chrome with VS 2015 Update 2 RC there is a compiler error:
> 
> 1>  texture_definition.cc
> 1>base/memory/ref_counted.h(414): error C2027: use of undefined type
'gpu::gles2::GLStreamTextureImage'
> 1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of
'gpu::gles2::GLStreamTextureImage'
> 1>  base/memory/ref_counted.h(413): note: while compiling class template
member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T
*)'
> 
> This is caused by a compiler bug, together with a type trait used in
> std::vector:
> https://twitter.com/StephanTLavavej/status/710191543840219136
> 
> A VS bug has been filed at:
> https://connect.microsoft.com/VisualStudio/feedback/details/2475971
> 
> Bug 595189 has a more minimal repro.
> 
> BUG=440500,595189
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0
> Cr-Commit-Position: refs/heads/master@{#381640}

TBR=piman@chromium.org,zmo@chromium.org,jmadill@chromium.org,geofflang@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,595189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Revert of Fix VS 2015 Update 2 specific bug (patchset #3 id:40001 of
https://codereview.chromium.org/1806743002/ )

Reason for revert:
This was a compiler bug workaround and the bug was fixed long ago. Note that
the #include "gpu/gpu_export.h" line that was added for the workaround is
being left in because it is now needed.

Original issue's description:
> Fix VS 2015 Update 2 specific bug
> 
> When building Chrome with VS 2015 Update 2 RC there is a compiler error:
> 
> 1>  texture_definition.cc
> 1>base/memory/ref_counted.h(414): error C2027: use of undefined type
'gpu::gles2::GLStreamTextureImage'
> 1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of
'gpu::gles2::GLStreamTextureImage'
> 1>  base/memory/ref_counted.h(413): note: while compiling class template
member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T
*)'
> 
> This is caused by a compiler bug, together with a type trait used in
> std::vector:
> https://twitter.com/StephanTLavavej/status/710191543840219136
> 
> A VS bug has been filed at:
> https://connect.microsoft.com/VisualStudio/feedback/details/2475971
> 
> Bug 595189 has a more minimal repro.
> 
> BUG=440500,595189
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0
> Cr-Commit-Position: refs/heads/master@{#381640}

TBR=piman@chromium.org,zmo@chromium.org,jmadill@chromium.org,geofflang@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,595189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[brucedawson, 2017-02-24 01:36:18]

Description was changed from

==========
Revert of Fix VS 2015 Update 2 specific bug (patchset #3 id:40001 of
https://codereview.chromium.org/1806743002/ )

Reason for revert:
This was a compiler bug workaround and the bug was fixed long ago. Note that
the #include "gpu/gpu_export.h" line that was added for the workaround is
being left in because it is now needed.

Original issue's description:
> Fix VS 2015 Update 2 specific bug
> 
> When building Chrome with VS 2015 Update 2 RC there is a compiler error:
> 
> 1>  texture_definition.cc
> 1>base/memory/ref_counted.h(414): error C2027: use of undefined type
'gpu::gles2::GLStreamTextureImage'
> 1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of
'gpu::gles2::GLStreamTextureImage'
> 1>  base/memory/ref_counted.h(413): note: while compiling class template
member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T
*)'
> 
> This is caused by a compiler bug, together with a type trait used in
> std::vector:
> https://twitter.com/StephanTLavavej/status/710191543840219136
> 
> A VS bug has been filed at:
> https://connect.microsoft.com/VisualStudio/feedback/details/2475971
> 
> Bug 595189 has a more minimal repro.
> 
> BUG=440500,595189
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0
> Cr-Commit-Position: refs/heads/master@{#381640}

TBR=piman@chromium.org,zmo@chromium.org,jmadill@chromium.org,geofflang@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,595189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Revert of Fix VS 2015 Update 2 specific bug (patchset #3 id:40001 of
https://codereview.chromium.org/1806743002/ )

Reason for revert:
This was a compiler bug workaround and the bug was fixed long ago. Note that
the #include "gpu/gpu_export.h" line that was added for the workaround is
being left in because it is now needed.

Original issue's description:
> Fix VS 2015 Update 2 specific bug
> 
> When building Chrome with VS 2015 Update 2 RC there is a compiler error:
> 
> 1>  texture_definition.cc
> 1>base/memory/ref_counted.h(414): error C2027: use of undefined type
'gpu::gles2::GLStreamTextureImage'
> 1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of
'gpu::gles2::GLStreamTextureImage'
> 1>  base/memory/ref_counted.h(413): note: while compiling class template
member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T
*)'
> 
> This is caused by a compiler bug, together with a type trait used in
> std::vector:
> https://twitter.com/StephanTLavavej/status/710191543840219136
> 
> A VS bug has been filed at:
> https://connect.microsoft.com/VisualStudio/feedback/details/2475971
> 
> Bug 595189 has a more minimal repro.
> 
> BUG=440500,595189
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0
> Cr-Commit-Position: refs/heads/master@{#381640}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,595189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[brucedawson, 2017-02-24 01:36:18]

brucedawson@chromium.org changed reviewers:
- geofflang@chromium.org, jmadill@chromium.org, piman@chromium.org

[brucedawson, 2017-02-24 01:37:09]

Simple change to remove an old compiler bug workaround. PTAL.

[commit-bot: I haz the power, 2017-02-24 02:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 02:39:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brucedawson, 2017-02-24 18:17:03]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 18:17:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 18:58:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 18:58:39]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2017-02-28 19:44:56]

On 2017/02/24 01:37:09, brucedawson wrote:
> Simple change to remove an old compiler bug workaround. PTAL.

lgtm

[brucedawson, 2017-02-28 20:06:59]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-02-28 20:07:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 21:19:23]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1488312419036770,
"parent_rev": "1f61d17535162589a708f0930985554c8fd092f7", "commit_rev":
"39e9ce2fb50f025d2176f24e90d3f2ea15a940fd"}

[commit-bot: I haz the power, 2017-02-28 21:20:03]

Description was changed from

==========
Revert of Fix VS 2015 Update 2 specific bug (patchset #3 id:40001 of
https://codereview.chromium.org/1806743002/ )

Reason for revert:
This was a compiler bug workaround and the bug was fixed long ago. Note that
the #include "gpu/gpu_export.h" line that was added for the workaround is
being left in because it is now needed.

Original issue's description:
> Fix VS 2015 Update 2 specific bug
> 
> When building Chrome with VS 2015 Update 2 RC there is a compiler error:
> 
> 1>  texture_definition.cc
> 1>base/memory/ref_counted.h(414): error C2027: use of undefined type
'gpu::gles2::GLStreamTextureImage'
> 1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of
'gpu::gles2::GLStreamTextureImage'
> 1>  base/memory/ref_counted.h(413): note: while compiling class template
member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T
*)'
> 
> This is caused by a compiler bug, together with a type trait used in
> std::vector:
> https://twitter.com/StephanTLavavej/status/710191543840219136
> 
> A VS bug has been filed at:
> https://connect.microsoft.com/VisualStudio/feedback/details/2475971
> 
> Bug 595189 has a more minimal repro.
> 
> BUG=440500,595189
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0
> Cr-Commit-Position: refs/heads/master@{#381640}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,595189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Revert of Fix VS 2015 Update 2 specific bug (patchset #3 id:40001 of
https://codereview.chromium.org/1806743002/ )

Reason for revert:
This was a compiler bug workaround and the bug was fixed long ago. Note that
the #include "gpu/gpu_export.h" line that was added for the workaround is
being left in because it is now needed.

Original issue's description:
> Fix VS 2015 Update 2 specific bug
> 
> When building Chrome with VS 2015 Update 2 RC there is a compiler error:
> 
> 1>  texture_definition.cc
> 1>base/memory/ref_counted.h(414): error C2027: use of undefined type
'gpu::gles2::GLStreamTextureImage'
> 1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of
'gpu::gles2::GLStreamTextureImage'
> 1>  base/memory/ref_counted.h(413): note: while compiling class template
member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T
*)'
> 
> This is caused by a compiler bug, together with a type trait used in
> std::vector:
> https://twitter.com/StephanTLavavej/status/710191543840219136
> 
> A VS bug has been filed at:
> https://connect.microsoft.com/VisualStudio/feedback/details/2475971
> 
> Bug 595189 has a more minimal repro.
> 
> BUG=440500,595189
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0
> Cr-Commit-Position: refs/heads/master@{#381640}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,595189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2710683014
Cr-Commit-Position: refs/heads/master@{#453704}
Committed:
https://chromium.googlesource.com/chromium/src/+/39e9ce2fb50f025d2176f24e90d3...
==========

[commit-bot: I haz the power, 2017-02-28 21:20:05]

Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/39e9ce2fb50f025d2176f24e90d3...