Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Issue 2710683006: sandbox tests: Adapt test expectations to new CHECK() behavior (Closed)

Created:
3 years, 10 months ago by Alexander Alekseev
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3020
Project:
chromium
Visibility:
Public.

Description

sandbox tests: Adapt test expectations to new CHECK() behavior Adapt the test expectations to the changes to official CHECK() introduced by https://crrev.com/2705053002. After that CL, CHECK() almost always causes a SIGTRAP with the exception of armv7 code running on a 32-bit arm kernel, where it causes a SIGBUS. However, the latter case is not interesting for the sandbox as it is not enabled on 32-bit arm kernels due to the lack of tsync. BUG=694652 TEST=Build with is_official_build=true, run out/X/sandbox_linux_unittests Review-Url: https://codereview.chromium.org/2709203002 Cr-Commit-Position: refs/heads/master@{#452125} (cherry picked from commit 5d04cccc168b54e6d05f7e9efbb180d87583b30b) Review-Url: https://codereview.chromium.org/2710683006 . Cr-Commit-Position: refs/branch-heads/3020@{#3} Cr-Branched-From: 22a030be0c75c7a39b938d51d04bcc259bf9fe17-refs/heads/master@{#451874} Committed: https://chromium.googlesource.com/chromium/src/+/83662024bf52a68136f147e498d861b23e3c9203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M sandbox/linux/syscall_broker/broker_file_permission_unittest.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M sandbox/linux/tests/unit_tests.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexander Alekseev
3 years, 10 months ago (2017-02-22 19:35:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83662024bf52a68136f147e498d861b23e3c9203.

Powered by Google App Engine
This is Rietveld 408576698