Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2709203002: sandbox tests: Adapt test expectations to new CHECK() behavior (Closed)

Created:
3 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, jln+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandbox tests: Adapt test expectations to new CHECK() behavior Adapt the test expectations to the changes to official CHECK() introduced by https://crrev.com/2705053002. After that CL, CHECK() almost always causes a SIGTRAP with the exception of armv7 code running on a 32-bit arm kernel, where it causes a SIGBUS. However, the latter case is not interesting for the sandbox as it is not enabled on 32-bit arm kernels due to the lack of tsync. BUG=694652 TEST=Build with is_official_build=true, run out/X/sandbox_linux_unittests Review-Url: https://codereview.chromium.org/2709203002 Cr-Commit-Position: refs/heads/master@{#452125} Committed: https://chromium.googlesource.com/chromium/src/+/5d04cccc168b54e6d05f7e9efbb180d87583b30b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M sandbox/linux/syscall_broker/broker_file_permission_unittest.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M sandbox/linux/tests/unit_tests.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Primiano Tucci (use gerrit)
rsesek PTAL
3 years, 10 months ago (2017-02-22 11:04:20 UTC) #4
Robert Sesek
LGTM
3 years, 10 months ago (2017-02-22 17:20:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709203002/1
3 years, 10 months ago (2017-02-22 17:57:38 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 18:07:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d04cccc168b54e6d05f7e9efbb1...

Powered by Google App Engine
This is Rietveld 408576698