Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2710673006: [Doodle] Pull a doodle_types.h out of doodle_fetcher.h (Closed)

Created:
3 years, 10 months ago by Marc Treib
Modified:
3 years, 10 months ago
Reviewers:
fhorschig, sfiera, mastiz
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Doodle] Pull a doodle_types.h out of doodle_fetcher.h This will ease further changes, such as separating a DoodleFetcher interface from the Impl, and adding a DoodleService. BUG=690467 Review-Url: https://codereview.chromium.org/2710673006 Cr-Commit-Position: refs/heads/master@{#452103} Committed: https://chromium.googlesource.com/chromium/src/+/5dae4677eefa9631e709b9d82b62417b01a98dc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -53 lines) Patch
M components/doodle/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/doodle/doodle_fetcher.h View 2 chunks +1 line, -53 lines 0 comments Download
A components/doodle/doodle_types.h View 1 chunk +67 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
Marc Treib
PTAL!
3 years, 10 months ago (2017-02-22 13:54:32 UTC) #3
fhorschig
lgtm
3 years, 10 months ago (2017-02-22 14:50:17 UTC) #5
Marc Treib
+mastiz - can I get a committer approval, please?
3 years, 10 months ago (2017-02-22 14:54:59 UTC) #7
Marc Treib
Since mastiz is out now: sfiera, can I get a stamp from you? (1/2)
3 years, 10 months ago (2017-02-22 16:42:59 UTC) #11
sfiera
LGTM
3 years, 10 months ago (2017-02-22 17:07:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710673006/1
3 years, 10 months ago (2017-02-22 17:11:35 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 17:17:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5dae4677eefa9631e709b9d82b62...

Powered by Google App Engine
This is Rietveld 408576698