[Doodle] Split DoodleFetcher into interface + Impl

[Doodle] Split DoodleFetcher into interface + Impl

This will make it easy to use fakes or mocks in tests.

BUG=690467
Review-Url: https://codereview.chromium.org/2707293002
Cr-Commit-Position: refs/heads/master@{#452473}
Committed: https://chromium.googlesource.com/chromium/src/+/89bae66c5cf1b268665973046236e6bf3722796e

[Marc Treib, 2017-02-22 14:28:22]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 14:28:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-02-22 14:29:50]

treib@chromium.org changed reviewers:
+ fhorschig@chromium.org

[Marc Treib, 2017-02-22 14:29:50]

Aaand another one, PTAL!
(Based on https://codereview.chromium.org/2710673006/, so look at that first.)

[fhorschig, 2017-02-22 14:57:18]

lgtm

https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
File components/doodle/doodle_fetcher.h (right):

https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
components/doodle/doodle_fetcher.h:8: #include "base/callback_forward.h"
Nice, didn't know that was possible!

[Marc Treib, 2017-02-22 14:59:55]

treib@chromium.org changed reviewers:
+ mastiz@chromium.org

[Marc Treib, 2017-02-22 14:59:55]

And another one - mastiz, I can haz approval plz? :)

[commit-bot: I haz the power, 2017-02-22 15:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 15:33:24]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-02-22 16:43:10]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2017-02-22 16:43:11]

Since mastiz is out now: sfiera, can I get a stamp from you? (2/2)

[sfiera, 2017-02-22 17:04:55]

LGTM

https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
File components/doodle/doodle_fetcher.h (right):

https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
components/doodle/doodle_fetcher.h:38: DISALLOW_COPY_AND_ASSIGN(DoodleFetcher);
Is this normal for abstract classes that can't be instantiated anyway? I assume
you don't need the default constructor above without it.

[Marc Treib, 2017-02-22 17:17:21]

https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
File components/doodle/doodle_fetcher.h (right):

https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
components/doodle/doodle_fetcher.h:38: DISALLOW_COPY_AND_ASSIGN(DoodleFetcher);
On 2017/02/22 17:04:55, sfiera wrote:
> Is this normal for abstract classes that can't be instantiated anyway? I
assume
> you don't need the default constructor above without it.

Hm, I *think* I've seen it before, but it doesn't seem to be very common, at
least in our corner of the world.

This way, the non-copyability is part of the interface. I'm not sure if it
should be; probably doesn't make much of a difference in practice. Do you think
I should remove it?

[sfiera, 2017-02-22 17:38:56]

On 2017/02/22 17:17:21, Marc Treib wrote:
>
https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
> File components/doodle/doodle_fetcher.h (right):
> 
>
https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
> components/doodle/doodle_fetcher.h:38:
DISALLOW_COPY_AND_ASSIGN(DoodleFetcher);
> On 2017/02/22 17:04:55, sfiera wrote:
> > Is this normal for abstract classes that can't be instantiated anyway? I
> assume
> > you don't need the default constructor above without it.
> 
> Hm, I *think* I've seen it before, but it doesn't seem to be very common, at
> least in our corner of the world.
> 
> This way, the non-copyability is part of the interface. I'm not sure if it
> should be; probably doesn't make much of a difference in practice. Do you
think
> I should remove it?

I think it's not the business of the interface to specify this. Subclasses
should probably have DISALLOW anyway, and anyone with only a pointer to the
interface can't copy it.

[Marc Treib, 2017-02-23 11:24:58]

On 2017/02/22 17:38:56, sfiera wrote:
> On 2017/02/22 17:17:21, Marc Treib wrote:
> >
>
https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
> > File components/doodle/doodle_fetcher.h (right):
> > 
> >
>
https://codereview.chromium.org/2707293002/diff/1/components/doodle/doodle_fe...
> > components/doodle/doodle_fetcher.h:38:
> DISALLOW_COPY_AND_ASSIGN(DoodleFetcher);
> > On 2017/02/22 17:04:55, sfiera wrote:
> > > Is this normal for abstract classes that can't be instantiated anyway? I
> > assume
> > > you don't need the default constructor above without it.
> > 
> > Hm, I *think* I've seen it before, but it doesn't seem to be very common, at
> > least in our corner of the world.
> > 
> > This way, the non-copyability is part of the interface. I'm not sure if it
> > should be; probably doesn't make much of a difference in practice. Do you
> think
> > I should remove it?
> 
> I think it's not the business of the interface to specify this. Subclasses
> should probably have DISALLOW anyway, and anyone with only a pointer to the
> interface can't copy it.

Fair enough; done.

[Marc Treib, 2017-02-23 11:25:02]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 11:25:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 11:26:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 11:26:28]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Marc Treib, 2017-02-23 11:34:37]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 11:34:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-02-23 12:33:50]

The CQ bit was unchecked by treib@chromium.org

[Marc Treib, 2017-02-23 12:33:50]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-02-23 12:33:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
fhorschig@chromium.org, sfiera@chromium.org
Link to the patchset: https://codereview.chromium.org/2707293002/#ps20001
(title: "review")

[commit-bot: I haz the power, 2017-02-23 12:34:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 12:43:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487853230953760,
"parent_rev": "f2665504267f4bdf38afc25af18d59ca0229f953", "commit_rev":
"89bae66c5cf1b268665973046236e6bf3722796e"}

[commit-bot: I haz the power, 2017-02-23 12:44:03]

Description was changed from

==========
[Doodle] Split DoodleFetcher into interface + Impl

This will make it easy to use fakes or mocks in tests.

BUG=690467
==========

to

==========
[Doodle] Split DoodleFetcher into interface + Impl

This will make it easy to use fakes or mocks in tests.

BUG=690467

Review-Url: https://codereview.chromium.org/2707293002
Cr-Commit-Position: refs/heads/master@{#452473}
Committed:
https://chromium.googlesource.com/chromium/src/+/89bae66c5cf1b268665973046236...
==========

[commit-bot: I haz the power, 2017-02-23 12:44:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/89bae66c5cf1b268665973046236...