Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2710673003: cros: Remove usage of GaiaScreenHandler outside of login/webui. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Remove usage of GaiaScreenHandler outside of webui/chromeos/login. BUG=672142 Review-Url: https://codereview.chromium.org/2710673003 Cr-Commit-Position: refs/heads/master@{#453029} Committed: https://chromium.googlesource.com/chromium/src/+/a7ffcc0b765e31ec060f05994d29623c17e00d71

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -65 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/gaia_screen.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/screens/gaia_screen.cc View 1 chunk +2 lines, -18 lines 0 comments Download
A chrome/browser/chromeos/login/screens/gaia_view.h View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 3 chunks +27 lines, -29 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (19 generated)
jdufault
alemate@ PTAL.
3 years, 10 months ago (2017-02-23 20:22:04 UTC) #17
Alexander Alekseev
lgtm
3 years, 10 months ago (2017-02-24 10:11:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710673003/40001
3 years, 10 months ago (2017-02-24 22:29:21 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 00:54:41 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a7ffcc0b765e31ec060f05994d29...

Powered by Google App Engine
This is Rietveld 408576698