PlzNavigate: remove NavigatorImpl::FailedNavigation

PlzNavigate: remove NavigatorImpl::FailedNavigation

This CL removes NavigatorImpl::FailedNavigation and move its code into
its sole caller, NavigationRequest::OnRequestFailed. This makes it
easier to update the navigation url if the commit of the error page
would result in a renderer kill (see
https://codereview.chromium.org/2697713005/).

BUG=622385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2710643003
Cr-Commit-Position: refs/heads/master@{#452025}
Committed: https://chromium.googlesource.com/chromium/src/+/5ca4b227e9d0a48b9ff8af941ff69a760305f034

[clamy, 2017-02-21 15:30:31]

Description was changed from

==========
PlzNavigate: remove NavigatorImpl::FailedNavigation

This CL removes NavigatorImpl::FailedNavigation and move its code into
its sole caller, NavigationRequest::OnRequestFailed. This makes it
easier to update the navigation url if the commit of the error page
would result in a renderer kill (see
https://codereview.chromium.org/2697713005/).

BUG=622385
==========

to

==========
PlzNavigate: remove NavigatorImpl::FailedNavigation

This CL removes NavigatorImpl::FailedNavigation and move its code into
its sole caller, NavigationRequest::OnRequestFailed. This makes it
easier to update the navigation url if the commit of the error page
would result in a renderer kill (see
https://codereview.chromium.org/2697713005/).

BUG=622385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-02-21 15:30:36]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:31:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2017-02-21 15:32:37]

Description was changed from

==========
PlzNavigate: remove NavigatorImpl::FailedNavigation

This CL removes NavigatorImpl::FailedNavigation and move its code into
its sole caller, NavigationRequest::OnRequestFailed. This makes it
easier to update the navigation url if the commit of the error page
would result in a renderer kill (see
https://codereview.chromium.org/2697713005/).

BUG=622385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: remove NavigatorImpl::FailedNavigation

This CL removes NavigatorImpl::FailedNavigation and move its code into
its sole caller, NavigationRequest::OnRequestFailed. This makes it
easier to update the navigation url if the commit of the error page
would result in a renderer kill (see
https://codereview.chromium.org/2697713005/).

BUG=622385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-02-21 15:32:37]

clamy@chromium.org changed reviewers:
+ arthursonzogni@chromium.org

[clamy, 2017-02-21 15:32:49]

@arthursonzogni: PTAL

[arthursonzogni, 2017-02-21 16:37:40]

Thanks LGTM!

[commit-bot: I haz the power, 2017-02-21 17:26:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:26:07]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[clamy, 2017-02-22 12:17:28]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2017-02-22 12:17:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 13:20:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487765848703310, "parent_rev":
"8c112333b3a0eff529b84d80437c3d27c519142f", "commit_rev":
"5ca4b227e9d0a48b9ff8af941ff69a760305f034"}

[commit-bot: I haz the power, 2017-02-22 13:20:51]

Description was changed from

==========
PlzNavigate: remove NavigatorImpl::FailedNavigation

This CL removes NavigatorImpl::FailedNavigation and move its code into
its sole caller, NavigationRequest::OnRequestFailed. This makes it
easier to update the navigation url if the commit of the error page
would result in a renderer kill (see
https://codereview.chromium.org/2697713005/).

BUG=622385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: remove NavigatorImpl::FailedNavigation

This CL removes NavigatorImpl::FailedNavigation and move its code into
its sole caller, NavigationRequest::OnRequestFailed. This makes it
easier to update the navigation url if the commit of the error page
would result in a renderer kill (see
https://codereview.chromium.org/2697713005/).

BUG=622385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2710643003
Cr-Commit-Position: refs/heads/master@{#452025}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ca4b227e9d0a48b9ff8af941ff6...
==========

[commit-bot: I haz the power, 2017-02-22 13:20:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ca4b227e9d0a48b9ff8af941ff6...