Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 2710643003: PlzNavigate: remove NavigatorImpl::FailedNavigation (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/browser/frame_host/navigation_handle_impl.h" 10 #include "content/browser/frame_host/navigation_handle_impl.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 bool proceed) {} 150 bool proceed) {}
151 151
152 // PlzNavigate 152 // PlzNavigate
153 // Used to start a new renderer-initiated navigation, following a 153 // Used to start a new renderer-initiated navigation, following a
154 // BeginNavigation IPC from the renderer. 154 // BeginNavigation IPC from the renderer.
155 virtual void OnBeginNavigation(FrameTreeNode* frame_tree_node, 155 virtual void OnBeginNavigation(FrameTreeNode* frame_tree_node,
156 const CommonNavigationParams& common_params, 156 const CommonNavigationParams& common_params,
157 const BeginNavigationParams& begin_params); 157 const BeginNavigationParams& begin_params);
158 158
159 // PlzNavigate 159 // PlzNavigate
160 // Called when a NavigationRequest for |frame_tree_node| failed. An
161 // appropriate RenderFrameHost should be selected and asked to show an error
162 // page. |has_stale_copy_in_cache| is true if there is a stale copy of the
163 // unreachable page in cache.
164 virtual void FailedNavigation(FrameTreeNode* frame_tree_node,
165 bool has_stale_copy_in_cache,
166 int error_code) {}
167
168 // PlzNavigate
169 // Cancel a NavigationRequest for |frame_tree_node|. Called when 160 // Cancel a NavigationRequest for |frame_tree_node|. Called when
170 // |frame_tree_node| is destroyed. 161 // |frame_tree_node| is destroyed.
171 virtual void CancelNavigation(FrameTreeNode* frame_tree_node) {} 162 virtual void CancelNavigation(FrameTreeNode* frame_tree_node) {}
172 163
173 // Called when the network stack started handling the navigation request 164 // Called when the network stack started handling the navigation request
174 // so that the |timestamp| when it happened can be recorded into an histogram. 165 // so that the |timestamp| when it happened can be recorded into an histogram.
175 // The |url| is used to verify we're tracking the correct navigation. 166 // The |url| is used to verify we're tracking the correct navigation.
176 // TODO(carlosk): once PlzNavigate is the only navigation implementation 167 // TODO(carlosk): once PlzNavigate is the only navigation implementation
177 // remove the URL parameter and rename this method to better suit its naming 168 // remove the URL parameter and rename this method to better suit its naming
178 // conventions. 169 // conventions.
(...skipping 11 matching lines...) Expand all
190 virtual void DiscardPendingEntryIfNeeded(NavigationHandleImpl* handle) {} 181 virtual void DiscardPendingEntryIfNeeded(NavigationHandleImpl* handle) {}
191 182
192 protected: 183 protected:
193 friend class base::RefCounted<Navigator>; 184 friend class base::RefCounted<Navigator>;
194 virtual ~Navigator() {} 185 virtual ~Navigator() {}
195 }; 186 };
196 187
197 } // namespace content 188 } // namespace content
198 189
199 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 190 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698