Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2710623002: Enforce FirstContentfulPaint <= FirstMeaningfulPaint (Closed)

Created:
3 years, 10 months ago by Kunihiko Sakamoto
Modified:
3 years, 10 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enforce FirstContentfulPaint <= FirstMeaningfulPaint Before this patch, ordering of FirstContentfulPaint (FCP) and FirstMeaningfulPaint (FMP) was not guaranteed. This change enforces FCP <= FMP ordering, by reporting FCP timestamp as FMP if the last FMP candidate is before FCP. BUG=689376 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2710623002 Cr-Commit-Position: refs/heads/master@{#452412} Committed: https://chromium.googlesource.com/chromium/src/+/064e872bec2dc2bc381a493c6be6c0f24d672c4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Kunihiko Sakamoto
3 years, 10 months ago (2017-02-21 08:21:10 UTC) #6
kouhei (in TOK)
lgtm
3 years, 10 months ago (2017-02-21 21:29:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710623002/1
3 years, 10 months ago (2017-02-22 01:05:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-22 03:08:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710623002/1
3 years, 10 months ago (2017-02-23 04:04:17 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 05:52:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/064e872bec2dc2bc381a493c6be6...

Powered by Google App Engine
This is Rietveld 408576698