Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp

Issue 2710623002: Enforce FirstContentfulPaint <= FirstMeaningfulPaint (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp
index b28b460f85ef86d715936af54fdb218d3b279eff..842d2731b0604d96e2da5a3b072ac73c9e1196ee 100644
--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp
+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp
@@ -116,4 +116,14 @@ TEST_F(FirstMeaningfulPaintDetectorTest,
EXPECT_NE(paintTiming().firstMeaningfulPaint(), 0.0);
}
+TEST_F(FirstMeaningfulPaintDetectorTest,
+ FirstMeaningfulPaintShouldNotBeBeforeFirstContentfulPaint) {
+ paintTiming().markFirstPaint();
+ simulateLayoutAndPaint(10);
+ paintTiming().markFirstContentfulPaint();
+ simulateNetworkStable();
+ EXPECT_GE(paintTiming().firstMeaningfulPaint(),
+ paintTiming().firstContentfulPaint());
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698