Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2710583005: Move SVGElement::buildPendingResourcesIfNeeded to SVGTreeScopeResources (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SVGElement::buildPendingResourcesIfNeeded to SVGTreeScopeResources Move notification of a resource "appearing" to SVGTreeScopeResources, naming the method notifyResourceAvailable(). Simplify the handling of the pending resources map to avoid unnecessary hash-lookups in some cases. BUG=454767 Review-Url: https://codereview.chromium.org/2710583005 Cr-Commit-Position: refs/heads/master@{#452187} Committed: https://chromium.googlesource.com/chromium/src/+/34e13a2a406da5718e80b800d66e5835bcf2e16d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +2 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 10 months ago (2017-02-22 19:55:52 UTC) #6
Stephen Chennney
lgtm
3 years, 10 months ago (2017-02-22 20:00:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710583005/1
3 years, 10 months ago (2017-02-22 20:35:06 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 20:42:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34e13a2a406da5718e80b800d66e...

Powered by Google App Engine
This is Rietveld 408576698