Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2710583005: Move SVGElement::buildPendingResourcesIfNeeded to SVGTreeScopeResources (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp
index 20449abd48a4c0387e3465c3bc14d38fa0414158..b1890ab05ff9d1c30a8d8cf4925881823fc5b260 100644
--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp
@@ -111,36 +111,8 @@ void SVGElement::willRecalcStyle(StyleRecalcChange change) {
void SVGElement::buildPendingResourcesIfNeeded() {
if (!needsPendingResourceHandling() || !isConnected() || inUseShadowTree())
return;
-
- SVGTreeScopeResources& treeScopeResources =
- treeScope().ensureSVGTreeScopedResources();
- AtomicString resourceId = getIdAttribute();
- if (!treeScopeResources.hasPendingResource(resourceId))
- return;
- // Guaranteed by hasPendingResource.
- DCHECK(!resourceId.isEmpty());
-
- // Get pending elements for this id.
- SVGTreeScopeResources::SVGPendingElements* pendingElements =
- treeScopeResources.removePendingResource(resourceId);
- if (!pendingElements || pendingElements->isEmpty())
- return;
-
- // Rebuild pending resources for each client of a pending resource that is
- // being removed.
- for (Element* clientElement : *pendingElements) {
- DCHECK(clientElement->hasPendingResources());
- if (!clientElement->hasPendingResources())
- continue;
- // TODO(fs): Ideally we'd always resolve pending resources async instead of
- // inside insertedInto and svgAttributeChanged. For now we only do it for
- // <use> since that would stamp out DOM.
- if (isSVGUseElement(clientElement))
- toSVGUseElement(clientElement)->invalidateShadowTree();
- else
- clientElement->buildPendingResource();
- treeScopeResources.clearHasPendingResourcesIfPossible(clientElement);
- }
+ treeScope().ensureSVGTreeScopedResources().notifyResourceAvailable(
+ getIdAttribute());
}
SVGElementRareData* SVGElement::ensureSVGRareData() {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698