Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2710193005: gl_context_glx: Create a highest version core profile context. (Closed)

Created:
3 years, 10 months ago by Corentin Wallez
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marcheu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gl_context_glx: Create a highest version core profile context. Previously the code was hitting a weirdness of glXCreateConfigAttrib where a compatilibility context was created even if the core profile bit was set. BUG=chromium:694877 Review-Url: https://codereview.chromium.org/2710193005 Cr-Commit-Position: refs/heads/master@{#452817} Committed: https://chromium.googlesource.com/chromium/src/+/ff06d6bb2507b7d412a0ccb283ed977c10023110

Patch Set 1 #

Patch Set 2 : gl_surface_glx: Implement GetFormat to silence an UNIMPLEMENTED #

Patch Set 3 : gl_context_glx: Create a highest version core profile context. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -55 lines) Patch
M ui/gl/gl_context_glx.cc View 2 1 chunk +54 lines, -55 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Corentin Wallez
Hey Ken, PTAL, this makes Chrome use a core profile, when this sticks I'll make ...
3 years, 10 months ago (2017-02-23 20:58:39 UTC) #8
Ken Russell (switch to Gerrit)
Very nice Corentin. Thanks for doing this. Hopefully it will stick. LGTM CC'ing marcheu as ...
3 years, 10 months ago (2017-02-24 00:59:14 UTC) #9
Corentin Wallez
Thanks for the review, I think it won't affect ChromeOS at all because this is ...
3 years, 10 months ago (2017-02-24 14:13:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710193005/40001
3 years, 10 months ago (2017-02-24 14:13:16 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ff06d6bb2507b7d412a0ccb283ed977c10023110
3 years, 10 months ago (2017-02-24 14:17:44 UTC) #15
marcheu
3 years, 10 months ago (2017-02-24 17:52:02 UTC) #17
Message was sent while issue was closed.
yes, chrome OS is not using GLX any longer, so this shouldn't break/fix anything
for it

Powered by Google App Engine
This is Rietveld 408576698