gl_context_glx: Create a highest version core profile context.

gl_context_glx: Create a highest version core profile context.

Previously the code was hitting a weirdness of glXCreateConfigAttrib
where a compatilibility context was created even if the core profile
bit was set.

BUG=chromium:694877
Review-Url: https://codereview.chromium.org/2710193005
Cr-Commit-Position: refs/heads/master@{#452817}
Committed: https://chromium.googlesource.com/chromium/src/+/ff06d6bb2507b7d412a0ccb283ed977c10023110

[Corentin Wallez, 2017-02-23 19:10:09]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 19:10:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Corentin Wallez, 2017-02-23 19:19:56]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 19:20:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 20:28:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 20:28:41]

Dry run: This issue passed the CQ dry run.

[Corentin Wallez, 2017-02-23 20:58:10]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org

[Corentin Wallez, 2017-02-23 20:58:39]

Hey Ken, PTAL, this makes Chrome use a core profile, when this sticks I'll make
the respective change in ANGLE.

[Ken Russell (switch to Gerrit), 2017-02-24 00:59:14]

Very nice Corentin. Thanks for doing this. Hopefully it will stick. LGTM

CC'ing marcheu as FYI because of earlier problems with using the Core Profile on
Linux with ChromeOS. I think this patch should address them.

[Corentin Wallez, 2017-02-24 14:13:06]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2017-02-24 14:13:07]

Thanks for the review, I think it won't affect ChromeOS at all because this is
in the GLX specific parts of ui/gl.

[commit-bot: I haz the power, 2017-02-24 14:13:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 14:17:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487945586639100,
"parent_rev": "4130eea2c32a5d3e0014ee9de21c16b2a55bb09f", "commit_rev":
"ff06d6bb2507b7d412a0ccb283ed977c10023110"}

[commit-bot: I haz the power, 2017-02-24 14:17:43]

Description was changed from

==========
gl_context_glx: Create a highest version core profile context.

Previously the code was hitting a weirdness of glXCreateConfigAttrib
where a compatilibility context was created even if the core profile
bit was set.

BUG=chromium:694877
==========

to

==========
gl_context_glx: Create a highest version core profile context.

Previously the code was hitting a weirdness of glXCreateConfigAttrib
where a compatilibility context was created even if the core profile
bit was set.

BUG=chromium:694877

Review-Url: https://codereview.chromium.org/2710193005
Cr-Commit-Position: refs/heads/master@{#452817}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff06d6bb2507b7d412a0ccb283ed...
==========

[commit-bot: I haz the power, 2017-02-24 14:17:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff06d6bb2507b7d412a0ccb283ed...

[marcheu, 2017-02-24 17:52:01]

marcheu@chromium.org changed reviewers:
+ marcheu@chromium.org

[marcheu, 2017-02-24 17:52:02]

yes, chrome OS is not using GLX any longer, so this shouldn't break/fix anything
for it