Update the analysis server integration tests to always run on the analysis driver.

Update the analysis server integration tests to always run on the analysis driver.

BUG=

[devoncarew, 2017-02-23 09:21:50]

devoncarew@google.com changed reviewers:
+ scheglov@google.com

[devoncarew, 2017-02-23 09:21:50]

- update the analysis server integration tests to only use the new driver
-add issues for tests which fail in the new driver

[Brian Wilkerson, 2017-02-23 15:17:32]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-02-23 15:17:33]

Does this mean that we've decided to remove the non-driver code paths and remove
the ability to disable it? Because I don't think we should remove the tests for
the non-driver code path until then.

[devoncarew, 2017-02-23 16:14:00]

I don't think we're going back to non-driver, and the work to remove technical
debt with the change will need to be spread out over time (I did ask about this
on an email thread a few days ago).

I think it's worth noting that some of the failures in the driver path didn't
have good visibility to me because of the test duplication. AS part of this CL I
found 3 failing driver integration tests (already known, but not to me).

[scheglov, 2017-02-23 16:22:05]

LGTM!

[Brian Wilkerson, 2017-02-23 17:58:18]

I'm not convinced that we're ready to make this change, but even if we do I
still think it would be better to remove the uses in the code and then the
tests. But if it were time to make this change, then the change itself lgtm.

https://codereview.chromium.org/2710193002/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/analysis/error_test.dart (right):

https://codereview.chromium.org/2710193002/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/analysis/error_test.dart:74: // We see
errors here with the new driver (#28870).
Move comments like this inside the method (or at least after the annotation,
otherwise sort will eventually cause the comment to move away from the method
and we'll loose this information.

[devoncarew, 2017-02-23 20:45:06]

> I'm not convinced that we're ready to make this change

It's not critical to make now, but at some point we'll want to make a call that
we can start removing non-driver code paths.

I'll hold off on this; let's figure out a cut-over date off-line.

[devoncarew, 2017-04-15 03:54:31]

Description was changed from

==========
Update the analysis server integration tests to always run on the analysis
driver.

BUG=
==========

to

==========
Update the analysis server integration tests to always run on the analysis
driver.

BUG=
==========